[Fasta] Do not emit default arguments at callsite

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.body_builder;
 
 import '../parser/parser.dart' show FormalParameterType, optional;
 
 import '../parser/error_kind.dart' show ErrorKind;
 
@@ skipping 1604 matching lines @@
     push(name);
   }
 
   @override
   Expression buildStaticInvocation(Member target, Arguments arguments,
       {bool isConst: false, int charOffset: -1}) {
     List<TypeParameter> typeParameters = target.function.typeParameters;
     if (target is Constructor) {
       typeParameters = target.enclosingClass.typeParameters;
     }
-    if (!addDefaultArguments(target.function, arguments, typeParameters)) {
+    if (!checkArguments(target.function, arguments, typeParameters)) {
       return throwNoSuchMethodError(target.name.name, arguments, charOffset);
     }
     if (target is Constructor) {
       return new ConstructorInvocation(target, arguments)..isConst = isConst;
     } else {
       return new StaticInvocation(target, arguments)..isConst = isConst;
     }
   }
 
-  bool addDefaultArguments(FunctionNode function, Arguments arguments,
+  bool checkArguments(FunctionNode function, Arguments arguments,
       List<TypeParameter> typeParameters) {
-    bool missingInitializers = false;
-
-    Expression defaultArgumentFrom(Expression expression) {
-      if (expression == null) {
-        missingInitializers = true;
-        return null;
-      }
-      cloner ??= new CloneVisitor();
-      return cloner.clone(expression);
-    }
 
     if (arguments.positional.length < function.requiredParameterCount ||
         arguments.positional.length > function.positionalParameters.length) {
       return false;
     }
-    for (int i = arguments.positional.length;
-        i < function.positionalParameters.length;
-        i++) {
-      var expression =
-          defaultArgumentFrom(function.positionalParameters[i].initializer);
-      expression?.parent = arguments;
-      arguments.positional.add(expression);
-    }
     Map<String, VariableDeclaration> names;
     if (function.namedParameters.isNotEmpty) {
       names = <String, VariableDeclaration>{};
       for (VariableDeclaration parameter in function.namedParameters) {
         names[parameter.name] = parameter;
       }
     }
     if (arguments.named.isNotEmpty) {
       if (names == null) return false;
       for (NamedExpression argument in arguments.named) {
         VariableDeclaration parameter = names.remove(argument.name);
         if (parameter == null) {
           return false;
         }
       }
     }
-    if (names != null) {
-      for (String name in names.keys) {
-        VariableDeclaration parameter = names[name];
-        arguments.named.add(new NamedExpression(
-            name, defaultArgumentFrom(parameter.initializer))
-          ..parent = arguments);
-      }
-    }
     if (typeParameters.length != arguments.types.length) {
       arguments.types.clear();
       for (int i = 0; i < typeParameters.length; i++) {
         arguments.types.add(const DynamicType());
       }
     }
 
-    if (missingInitializers) {
-      library.addArgumentsWithMissingDefaultValues(arguments, function);

[ahe, 2017/03/16 14:48:33]

Could you check if you can remove this method as well?

[Dmitry Olshansky, 2017/03/16 15:18:53]

Done.

-    }
     return true;
   }
 
   @override
   void handleNewExpression(Token token) {
     debugEvent("NewExpression");
     Arguments arguments = pop();
     String name = pop();
     List<DartType> typeArguments = pop();
     var type = pop();
@@ skipping 1074 matching lines @@
   } else if (node is PrefixBuilder) {
     return node.name;
   } else if (node is ThisAccessor) {
     return node.isSuper ? "super" : "this";
   } else if (node is BuilderAccessor) {
     return node.plainNameForRead;
   } else {
     return internalError("Unhandled: ${node.runtimeType}");
   }
 }