Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2752913002: Convert NULL to nullptr in transport security state generator. (Closed)

Created:
3 years, 9 months ago by martijnc
Modified:
3 years, 9 months ago
Reviewers:
Ryan Sleevi
CC:
cbentzel+watch_chromium.org, chromium-reviews, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert NULL to nullptr in transport security state generator. BUG=595493 R=rsleevi@chromium.org Review-Url: https://codereview.chromium.org/2752913002 Cr-Commit-Position: refs/heads/master@{#457199} Committed: https://chromium.googlesource.com/chromium/src/+/35b599a4faa768dd9b2f221193b104404f640d42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M net/http/transport_security_state_static.h View 12 chunks +14 lines, -14 lines 0 comments Download
M net/tools/transport_security_state_generator/cert_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/transport_security_state_generator/preloaded_state_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/tools/transport_security_state_generator/resources/transport_security_state_static.template View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
martijnc
As promised. Can you review? Thanks!
3 years, 9 months ago (2017-03-15 19:55:21 UTC) #5
Ryan Sleevi
lgtm
3 years, 9 months ago (2017-03-15 20:42:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752913002/40001
3 years, 9 months ago (2017-03-15 20:43:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 20:52:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/35b599a4faa768dd9b2f221193b1...

Powered by Google App Engine
This is Rietveld 408576698