Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2752793003: Re-enable LoginGuestTest. (Closed)

Created:
3 years, 9 months ago by achuithb
Modified:
3 years, 9 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable LoginGuestTest. There's one line that flakes that we still disable for this test. BUG=chromium:693106 TEST=LoginGuestTest.* Review-Url: https://codereview.chromium.org/2752793003 Cr-Commit-Position: refs/heads/master@{#457337} Committed: https://chromium.googlesource.com/chromium/src/+/5a22ca4cf2ae7796f308999cfdaa0ae8cd5705b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/browser/chromeos/login/login_browsertest.cc View 5 chunks +13 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
achuithb
Alex, please review.
3 years, 9 months ago (2017-03-15 22:15:00 UTC) #4
Alexander Alekseev
lgtm
3 years, 9 months ago (2017-03-15 22:59:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752793003/1
3 years, 9 months ago (2017-03-16 03:22:44 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 03:28:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a22ca4cf2ae7796f308999cfdaa...

Powered by Google App Engine
This is Rietveld 408576698