Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2752673003: DOM: adoptNode() should not crash by reparenting the specified node in removeChild(). (Closed)

Created:
3 years, 9 months ago by tkent
Modified:
3 years, 9 months ago
Reviewers:
hayato
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DOM: adoptNode() should not crash by reparenting the specified node in removeChild(). BUG=698574 Review-Url: https://codereview.chromium.org/2752673003 Cr-Commit-Position: refs/heads/master@{#457015} Committed: https://chromium.googlesource.com/chromium/src/+/99c1f4221e4374df51ebb65b24be45400dff150a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/dom/document/adoptNode-reparenting-crash.html View 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
hayato@, would you review this please?
3 years, 9 months ago (2017-03-15 04:41:08 UTC) #4
hayato
lgtm
3 years, 9 months ago (2017-03-15 06:43:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752673003/1
3 years, 9 months ago (2017-03-15 06:44:11 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 06:49:49 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/99c1f4221e4374df51ebb65b24be...

Powered by Google App Engine
This is Rietveld 408576698