Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: content/browser/bluetooth/web_bluetooth_service_impl.h

Issue 2752663002: Remove RemoteServerDisconnect() from web_bluetooth.mojom (Closed)
Patch Set: address scheib@'s comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/web_bluetooth_service_impl.h
diff --git a/content/browser/bluetooth/web_bluetooth_service_impl.h b/content/browser/bluetooth/web_bluetooth_service_impl.h
index 6e5e164b1684872e6f03e1f6741d40132cc07654..de84ea550aebdf367d33757df0b82f7f55d2ad4d 100644
--- a/content/browser/bluetooth/web_bluetooth_service_impl.h
+++ b/content/browser/bluetooth/web_bluetooth_service_impl.h
@@ -104,7 +104,6 @@ class CONTENT_EXPORT WebBluetoothServiceImpl
const WebBluetoothDeviceId& device_id,
blink::mojom::WebBluetoothServerClientAssociatedPtrInfo client,
const RemoteServerConnectCallback& callback) override;
- void RemoteServerDisconnect(const WebBluetoothDeviceId& device_id) override;
void RemoteServerGetPrimaryServices(
const WebBluetoothDeviceId& device_id,
blink::mojom::WebBluetoothGATTQueryQuantity quantity,
@@ -147,6 +146,11 @@ class CONTENT_EXPORT WebBluetoothServiceImpl
const RequestDeviceCallback& callback,
device::BluetoothAdapter* adapter);
+ // Called in the following two situations:
+ // 1. When a device is disconnected on the browser side.
scheib 2017/03/22 01:11:08 Let's reword to be a bit clearer, something like:
juncai 2017/03/27 20:44:46 Done.
+ // 2. When the renderer intentionally wants to disconnect from a device.
+ void HandleServerClientError(const WebBluetoothDeviceId& device_id);
scheib 2017/03/22 01:11:08 Perhaps: OnGATTServerClientDisconnection
juncai 2017/03/27 20:44:46 Done.
+
// Should only be run after the services have been discovered for
// |device_address|.
void RemoteServerGetPrimaryServicesImpl(

Powered by Google App Engine
This is Rietveld 408576698