Remove RemoteServerDisconnect() from web_bluetooth.mojom

content/browser/bluetooth/web_bluetooth_service_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_BLUETOOTH_WEB_BLUETOOTH_SERVICE_IMPL_H_
 #define CONTENT_BROWSER_BLUETOOTH_WEB_BLUETOOTH_SERVICE_IMPL_H_
 
 #include <memory>
 #include <string>
 #include <vector>
@@ skipping 86 matching lines @@
       const std::string& characteristic_instance_id,
       const std::vector<uint8_t>& value);
 
   // WebBluetoothService methods:
   void RequestDevice(blink::mojom::WebBluetoothRequestDeviceOptionsPtr options,
                      const RequestDeviceCallback& callback) override;
   void RemoteServerConnect(
       const WebBluetoothDeviceId& device_id,
       blink::mojom::WebBluetoothServerClientAssociatedPtrInfo client,
       const RemoteServerConnectCallback& callback) override;
-  void RemoteServerDisconnect(const WebBluetoothDeviceId& device_id) override;
   void RemoteServerGetPrimaryServices(
       const WebBluetoothDeviceId& device_id,
       blink::mojom::WebBluetoothGATTQueryQuantity quantity,
       const base::Optional<device::BluetoothUUID>& services_uuid,
       const RemoteServerGetPrimaryServicesCallback& callback) override;
   void RemoteServiceGetCharacteristics(
       const std::string& service_instance_id,
       blink::mojom::WebBluetoothGATTQueryQuantity quantity,
       const base::Optional<device::BluetoothUUID>& characteristics_uuid,
       const RemoteServiceGetCharacteristicsCallback& callback) override;
@@ skipping 22 matching lines @@
   void RemoteDescriptorWriteValue(
       const std::string& descriptor_instance_id,
       const std::vector<uint8_t>& value,
       const RemoteDescriptorWriteValueCallback& callback) override;
 
   void RequestDeviceImpl(
       blink::mojom::WebBluetoothRequestDeviceOptionsPtr options,
       const RequestDeviceCallback& callback,
       device::BluetoothAdapter* adapter);
 
+  // Called in the following two situations:
+  // 1. When a device is disconnected on the browser side.

[scheib, 2017/03/22 01:11:08]

Let's reword to be a bit clearer, something like:

Renderer has closed the pipe because it no longer needs a connection
to this device. Because:
1) Content script code has called disconnect()
2) The actual device disconnected, WebBluetoothServiceImpl informed the
renderer, and renderer reacted.

[juncai, 2017/03/27 20:44:46]

Done.

+  // 2. When the renderer intentionally wants to disconnect from a device.
+  void HandleServerClientError(const WebBluetoothDeviceId& device_id);

[scheib, 2017/03/22 01:11:08]

Perhaps: OnGATTServerClientDisconnection

[juncai, 2017/03/27 20:44:46]

Done.

+
   // Should only be run after the services have been discovered for
   // |device_address|.
   void RemoteServerGetPrimaryServicesImpl(
       const WebBluetoothDeviceId& device_id,
       blink::mojom::WebBluetoothGATTQueryQuantity quantity,
       const base::Optional<device::BluetoothUUID>& services_uuid,
       const RemoteServerGetPrimaryServicesCallback& callback,
       device::BluetoothDevice* device);
 
   // Callbacks for BluetoothDeviceChooserController::GetDevice.
@@ skipping 127 matching lines @@
   mojo::Binding<blink::mojom::WebBluetoothService> binding_;
 
   base::WeakPtrFactory<WebBluetoothServiceImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebBluetoothServiceImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_BLUETOOTH_WEB_BLUETOOTH_SERVICE_IMPL_H_