Change MojoDecryptorService to take a Decryptor

Change MojoDecryptorService to take a Decryptor

There is no need for MojoDecryptorService to take a reference to a
ContentDecryptionModule as the creator of the service already owns the CDM
and can control the lifetime of both objects. It cleans up the interface as
now the service simply implements the mojo interface on top of the actual
Decryptor.

BUG=701107
TEST=mojo_decryptor tests pass

Review-Url: https://codereview.chromium.org/2752653002
Cr-Commit-Position: refs/heads/master@{#456935}
Committed: https://chromium.googlesource.com/chromium/src/+/34a31a9a833423694d567a9de9d0214d0c25aaa1

[jrummell, 2017-03-14 17:53:15]

jrummell@chromium.org changed reviewers:
+ xhwang@chromium.org

[jrummell, 2017-03-14 17:53:15]

Cleanup as noted in the previous CL

[xhwang, 2017-03-14 22:07:19]

Thanks for the quick followup! LGTM with nits.

https://codereview.chromium.org/2752653002/diff/1/media/mojo/clients/mojo_dec...
File media/mojo/clients/mojo_decryptor_unittest.cc (right):

https://codereview.chromium.org/2752653002/diff/1/media/mojo/clients/mojo_dec...
media/mojo/clients/mojo_decryptor_unittest.cc:98: // Helpers needed by
|mojo_decryptor_service_|.
nit: the decryptor_ is not really a helper here ;)

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_cd...
File media/mojo/services/mojo_cdm_service.h (right):

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_cd...
media/mojo/services/mojo_cdm_service.h:109: // MojoDecryptorService will be
passed the Decryptor from |cdm_|, so
nit: "will be passed the Decryptor"?

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_de...
File media/mojo/services/mojo_decryptor_service.h (right):

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_de...
media/mojo/services/mojo_decryptor_service.h:38: // object.
nit: ensure that |decryptor| outlives |this|.

[jrummell, 2017-03-14 22:49:40]

Thanks for the review.

https://codereview.chromium.org/2752653002/diff/1/media/mojo/clients/mojo_dec...
File media/mojo/clients/mojo_decryptor_unittest.cc (right):

https://codereview.chromium.org/2752653002/diff/1/media/mojo/clients/mojo_dec...
media/mojo/clients/mojo_decryptor_unittest.cc:98: // Helpers needed by
|mojo_decryptor_service_|.
On 2017/03/14 22:07:19, xhwang_slow wrote:
> nit: the decryptor_ is not really a helper here ;)

Done.

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_cd...
File media/mojo/services/mojo_cdm_service.h (right):

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_cd...
media/mojo/services/mojo_cdm_service.h:109: // MojoDecryptorService will be
passed the Decryptor from |cdm_|, so
On 2017/03/14 22:07:19, xhwang_slow wrote:
> nit: "will be passed the Decryptor"?

Done.

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_de...
File media/mojo/services/mojo_decryptor_service.h (right):

https://codereview.chromium.org/2752653002/diff/1/media/mojo/services/mojo_de...
media/mojo/services/mojo_decryptor_service.h:38: // object.
On 2017/03/14 22:07:19, xhwang_slow wrote:
> nit: ensure that |decryptor| outlives |this|.

Done.

[jrummell, 2017-03-14 22:49:43]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2017-03-14 22:49:44]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2752653002/#ps20001
(title: "comments updated")

[commit-bot: I haz the power, 2017-03-14 22:50:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 01:18:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489531783777420,
"parent_rev": "8fdbfb2484873d09de132e051da87e580382f95b", "commit_rev":
"34a31a9a833423694d567a9de9d0214d0c25aaa1"}

[commit-bot: I haz the power, 2017-03-15 01:19:41]

Description was changed from

==========
Change MojoDecryptorService to take a Decryptor

There is no need for MojoDecryptorService to take a reference to a
ContentDecryptionModule as the creator of the service already owns the CDM
and can control the lifetime of both objects. It cleans up the interface as
now the service simply implements the mojo interface on top of the actual
Decryptor.

BUG=701107
TEST=mojo_decryptor tests pass
==========

to

==========
Change MojoDecryptorService to take a Decryptor

There is no need for MojoDecryptorService to take a reference to a
ContentDecryptionModule as the creator of the service already owns the CDM
and can control the lifetime of both objects. It cleans up the interface as
now the service simply implements the mojo interface on top of the actual
Decryptor.

BUG=701107
TEST=mojo_decryptor tests pass

Review-Url: https://codereview.chromium.org/2752653002
Cr-Commit-Position: refs/heads/master@{#456935}
Committed:
https://chromium.googlesource.com/chromium/src/+/34a31a9a833423694d567a9de9d0...
==========

[commit-bot: I haz the power, 2017-03-15 01:19:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/34a31a9a833423694d567a9de9d0...