Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2752593008: Move AcceleratorController from WmShell to Shell (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
James Cook
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, shuchen+watch_chromium.org, yzshen+watch_chromium.org, dmazzoni+watch_chromium.org, yusukes+watch_chromium.org, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, abarth-chromium, nona+watch_chromium.org, je_julie, chromium-apps-reviews_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, kalyank, tfarina, nektar+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, darin (slow to review), davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move AcceleratorController from WmShell to Shell Also moves AcceleratorControllerDelegateAura from Shell to WmShellAura. Access to AcceleratorControllerDelegateAura is now only WmShellAura to reinforce AcceleratorControllerDelegateAura is only in classic aura. BUG=687660 TEST=covered by tests R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2752593008 Cr-Commit-Position: refs/heads/master@{#457843} Committed: https://chromium.googlesource.com/chromium/src/+/81a2d796ecde51050ebf057af9426b251cad9028

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1

Patch Set 3 : fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -87 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/aura/wm_shell_aura.h View 4 chunks +8 lines, -0 lines 0 comments Download
M ash/aura/wm_shell_aura.cc View 1 3 chunks +17 lines, -0 lines 0 comments Download
M ash/common/accelerators/accelerator_router.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/common/accelerators/ash_focus_manager_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/common/mojo_interface_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/common/system/tray/system_tray_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/common/wm_shell.h View 1 4 chunks +4 lines, -8 lines 0 comments Download
M ash/common/wm_shell.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ash/mus/accelerators/accelerator_controller_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.h View 1 chunk +1 line, -0 lines 0 comments Download
M ash/mus/bridge/wm_shell_mus.cc View 1 2 chunks +21 lines, -12 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 3 chunks +4 lines, -6 lines 0 comments Download
M ash/shell.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M ash/test/ash_test_helper.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_pinning_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/automation/automation_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/global_shortcut_listener_chromeos.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_controller_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/ash_util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/palette_delegate_chromeos.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate_chromeos.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sky
3 years, 9 months ago (2017-03-17 17:50:31 UTC) #1
James Cook
LGTM https://codereview.chromium.org/2752593008/diff/20001/ash/common/wm_shell.h File ash/common/wm_shell.h (right): https://codereview.chromium.org/2752593008/diff/20001/ash/common/wm_shell.h#newcode332 ash/common/wm_shell.h:332: // Called during startup to create the AcceleratorController. ...
3 years, 9 months ago (2017-03-17 18:01:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752593008/40001
3 years, 9 months ago (2017-03-17 18:05:42 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-17 19:15:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/81a2d796ecde51050ebf057af942...

Powered by Google App Engine
This is Rietveld 408576698