Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2752593006: Utilize assert_selection() in editing/pasteboard/4242293-1.html (Closed)

Created:
3 years, 9 months ago by yosin_UTC9
Modified:
3 years, 9 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Utilize assert_selection() in editing/pasteboard/4242293-1.html This patch makes "4242293-1.html" to use |assert_selection()| to visualize test result and renames to "copy_ending_at_end_of_block.html" to provide a hint what this test script does for improving code health. This patch is a preparation of patch[1]. [1] http://crrev.com/2754543004: Make Selection#modify() with word granularity not to skip punctuation BUG=699903 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2752593006 Cr-Commit-Position: refs/heads/master@{#457602} Committed: https://chromium.googlesource.com/chromium/src/+/ce0eb87c0601121d065792c19c487a4580b4dd3e

Patch Set 1 : 2017-03-16T19:19:34 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
D third_party/WebKit/LayoutTests/editing/pasteboard/4242293-1.html View 1 chunk +0 lines, -32 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/pasteboard/copy_ending_at_end_of_block.html View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 9 months ago (2017-03-16 10:24:40 UTC) #5
tkent
lgtm
3 years, 9 months ago (2017-03-16 23:13:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752593006/1
3 years, 9 months ago (2017-03-16 23:14:11 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:21:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ce0eb87c0601121d065792c19c48...

Powered by Google App Engine
This is Rietveld 408576698