Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2752543006: Don't block blob URLs by webview URL filtering. (Closed)

Created:
3 years, 9 months ago by jam
Modified:
3 years, 9 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, jam, cbentzel+watch_chromium.org, darin-cc_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't block blob URLs by webview URL filtering. blob URLs are both used by PlzNavigate and sites that are whitelisted. This fixes PolicyUrlFilteringTest#testWhitelistedUrl with PlzNavigate. BUG=645983 Review-Url: https://codereview.chromium.org/2752543006 Cr-Commit-Position: refs/heads/master@{#456824} Committed: https://chromium.googlesource.com/chromium/src/+/db15896bc5eaa54e21480834265cfd82bd6cb8a5

Patch Set 1 #

Patch Set 2 : without PlzNavigate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M android_webview/browser/net/aw_network_delegate.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 9 months ago (2017-03-14 20:10:23 UTC) #5
sgurun-gerrit only
On 2017/03/14 20:10:23, jam wrote: lgtm
3 years, 9 months ago (2017-03-14 20:18:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752543006/40001
3 years, 9 months ago (2017-03-14 20:22:43 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 21:00:16 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db15896bc5eaa54e21480834265c...

Powered by Google App Engine
This is Rietveld 408576698