Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2752543003: Move FrameHost::m_subframeCount to Page (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FrameHost::m_subframeCount to Page Move the field FrameHost::m_subframeCount to Page, and update FrameHost methods to directly call the equivalent Page method. Reverted in https://codereview.chromium.org/2746873002/ due to failing WebKit Linux Trusty Leak, re-landing to see if error can be repro'd. TBR=haraken,joelhockey BUG=691794 Review-Url: https://codereview.chromium.org/2752543003 Cr-Commit-Position: refs/heads/master@{#457314} Committed: https://chromium.googlesource.com/chromium/src/+/2879e8ebd796a5a459f0297624b284e32ec6ae9a

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -34 lines) Patch
M third_party/WebKit/Source/core/dom/NodeRareData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 2 chunks +7 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752543003/1
3 years, 9 months ago (2017-03-14 05:06:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/408070)
3 years, 9 months ago (2017-03-14 07:05:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752543003/20001
3 years, 9 months ago (2017-03-16 01:53:34 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 02:17:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2879e8ebd796a5a459f0297624b2...

Powered by Google App Engine
This is Rietveld 408576698