Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issue 2752533003: Remove ScopedVector from content/browser/. (Closed)

Created:
3 years, 9 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, tracing+reviews_chromium.org, miu+watch_chromium.org, iclelland+watch_chromium.org, jam, chasej+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, jkarlin+watch_chromium.org, kalyank, xjz+watch_chromium.org, creis+watch_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, piman+watch_chromium.org, wfh+watch_chromium.org, shuchen+watch_chromium.org, dtapuska+chromiumwatch_chromium.org, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector from content/browser/. base::ScopedVector is deprecated, see bug. BUG=554289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2752533003 Cr-Commit-Position: refs/heads/master@{#456954} Committed: https://chromium.googlesource.com/chromium/src/+/9ed4df75318726707f5005682b105fc765d3893a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -64 lines) Patch
M content/browser/background_sync/background_sync_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M content/browser/background_sync/background_sync_manager_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/background_sync/background_sync_service_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_manager_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_handle_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/permissions/permission_service_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/presentation/presentation_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/synthetic_gesture_controller.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_sync_writer.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_process_host_unittest.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tracing/background_tracing_config_impl.h View 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/tracing/background_tracing_config_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/tracing/background_tracing_config_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 3 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
leonhsl(Using Gerrit)
PTAL, Thanks.
3 years, 9 months ago (2017-03-14 10:06:03 UTC) #7
Avi (use Gerrit)
lgtm
3 years, 9 months ago (2017-03-14 15:21:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752533003/1
3 years, 9 months ago (2017-03-15 02:10:15 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 02:17:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ed4df75318726707f5005682b10...

Powered by Google App Engine
This is Rietveld 408576698