Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: cc/output/software_renderer.cc

Issue 2752523006: cc: Use SkCreateColorSpaceXformCanvas for color transforms (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/debug/rasterize_and_record_benchmark_impl.cc ('k') | cc/playback/raster_source.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/software_renderer.cc
diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc
index 7c53b51347e17a59c32d9ff7e95d866773f04376..be0c4dd097f107af73ef018f19a0a0fe58a0c39e 100644
--- a/cc/output/software_renderer.cc
+++ b/cc/output/software_renderer.cc
@@ -336,6 +336,11 @@ void SoftwareRenderer::DrawPictureQuad(const PictureDrawQuad* quad) {
TRACE_EVENT0("cc", "SoftwareRenderer::DrawPictureQuad");
+ // TODO(ccameron): Determine a color space strategy for software rendering.
+ gfx::ColorSpace canvas_color_space;
+ if (settings_->enable_color_correct_rendering)
+ canvas_color_space = gfx::ColorSpace::CreateSRGB();
+
RasterSource::PlaybackSettings playback_settings;
playback_settings.playback_to_shared_canvas = true;
// Indicates whether content rasterization should happen through an
@@ -356,12 +361,12 @@ void SoftwareRenderer::DrawPictureQuad(const PictureDrawQuad* quad) {
quad->shared_quad_state->opacity,
disable_image_filtering);
quad->raster_source->PlaybackToCanvas(
- &filtered_canvas, quad->content_rect, quad->content_rect,
- quad->contents_scale, playback_settings);
+ &filtered_canvas, canvas_color_space, quad->content_rect,
+ quad->content_rect, quad->contents_scale, playback_settings);
} else {
quad->raster_source->PlaybackToCanvas(
- current_canvas_, quad->content_rect, quad->content_rect,
- quad->contents_scale, playback_settings);
+ current_canvas_, canvas_color_space, quad->content_rect,
+ quad->content_rect, quad->contents_scale, playback_settings);
}
}
« no previous file with comments | « cc/debug/rasterize_and_record_benchmark_impl.cc ('k') | cc/playback/raster_source.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698