Reporting: Implement browsing data remover.

Reporting: Implement browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.

BUG=704259
Review-Url: https://codereview.chromium.org/2752523005
Cr-Commit-Position: refs/heads/master@{#463016}
Committed: https://chromium.googlesource.com/chromium/src/+/1170eb931001e6307d73a250f8c7a7f2db2042a4

[Julia Tuttle, 2017-03-15 13:41:02]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 13:41:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 14:02:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:02:23]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Julia Tuttle, 2017-03-15 14:10:11]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 14:10:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 15:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 15:12:46]

Dry run: This issue passed the CQ dry run.

[Julia Tuttle, 2017-03-22 19:19:48]

juliatuttle@chromium.org changed reviewers:
+ shivanisha@chromium.org

[Julia Tuttle, 2017-03-22 19:19:49]

PTAL, shivanisha.

[Julia Tuttle, 2017-03-22 19:57:34]

Description was changed from

==========
Reporting: Create browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.
==========

to

==========
Reporting: Implement browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.
==========

[Julia Tuttle, 2017-03-22 20:00:46]

Description was changed from

==========
Reporting: Implement browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.
==========

to

==========
Reporting: Implement browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.

BUG=704259
==========

[Julia Tuttle, 2017-03-31 16:12:25]

The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 16:12:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[shivanisha, 2017-04-07 15:10:15]

On 2017/03/22 at 19:19:49, juliatuttle wrote:
> PTAL, shivanisha.

lgtm % nits

[shivanisha, 2017-04-07 15:10:31]

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
File net/reporting/reporting_browsing_data_remover.cc (right):

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
net/reporting/reporting_browsing_data_remover.cc:19: bool remove_clients,
nit: Enum in place of two boolean arguments.

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
File net/reporting/reporting_browsing_data_remover.h (right):

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
net/reporting/reporting_browsing_data_remover.h:17: class NET_EXPORT
ReportingBrowsingDataRemover {
Comment describing the overall purpose of the class.

[Julia Tuttle, 2017-04-07 16:25:10]

juliatuttle@chromium.org changed reviewers:
+ csharrison@chromium.org

[Julia Tuttle, 2017-04-07 16:25:11]

Thanks shivanisha! PTAL csharrison for committer signoff.

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
File net/reporting/reporting_browsing_data_remover.cc (right):

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
net/reporting/reporting_browsing_data_remover.cc:19: bool remove_clients,
On 2017/04/07 15:10:30, shivanisha wrote:
> nit: Enum in place of two boolean arguments.

Done.

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
File net/reporting/reporting_browsing_data_remover.h (right):

https://codereview.chromium.org/2752523005/diff/80001/net/reporting/reporting...
net/reporting/reporting_browsing_data_remover.h:17: class NET_EXPORT
ReportingBrowsingDataRemover {
On 2017/04/07 15:10:30, shivanisha wrote:
> Comment describing the overall purpose of the class.

Done.

[Charlie Harrison, 2017-04-07 16:32:27]

RS LGTM

[shivanisha, 2017-04-07 16:42:49]

https://codereview.chromium.org/2752523005/diff/120001/net/reporting/reportin...
File net/reporting/reporting_browsing_data_remover.cc (right):

https://codereview.chromium.org/2752523005/diff/120001/net/reporting/reportin...
net/reporting/reporting_browsing_data_remover.cc:21: bool remove_reports =
!!(data_type_mask & DATA_TYPE_REPORTS);
Why the 2 negate signs?

[Julia Tuttle, 2017-04-07 17:45:54]

On 2017/04/07 16:42:49, shivanisha wrote:
>
https://codereview.chromium.org/2752523005/diff/120001/net/reporting/reportin...
> File net/reporting/reporting_browsing_data_remover.cc (right):
> 
>
https://codereview.chromium.org/2752523005/diff/120001/net/reporting/reportin...
> net/reporting/reporting_browsing_data_remover.cc:21: bool remove_reports =
> !!(data_type_mask & DATA_TYPE_REPORTS);
> Why the 2 negate signs?

Makes it clearer that I'm doing the "non-zero => true, zero => false"
conversion. I could do != 0 if that's better.

[shivanisha, 2017-04-07 17:55:59]

On 2017/04/07 at 17:45:54, juliatuttle wrote:
> On 2017/04/07 16:42:49, shivanisha wrote:
> >
https://codereview.chromium.org/2752523005/diff/120001/net/reporting/reportin...
> > File net/reporting/reporting_browsing_data_remover.cc (right):
> > 
> >
https://codereview.chromium.org/2752523005/diff/120001/net/reporting/reportin...
> > net/reporting/reporting_browsing_data_remover.cc:21: bool remove_reports =
> > !!(data_type_mask & DATA_TYPE_REPORTS);
> > Why the 2 negate signs?
> 
> Makes it clearer that I'm doing the "non-zero => true, zero => false"
conversion. I could do != 0 if that's better.

!= 0 sgtm

[Julia Tuttle, 2017-04-07 20:18:00]

The CQ bit was checked by juliatuttle@chromium.org

[Julia Tuttle, 2017-04-07 20:18:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
shivanisha@chromium.org, csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2752523005/#ps140001
(title: "Make requested change.")

[commit-bot: I haz the power, 2017-04-07 20:18:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 21:55:03]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1491596280349680,
"parent_rev": "7f9c1f75fc3ddb2d9be2d7de0c8954fc0bb6dcfa", "commit_rev":
"1170eb931001e6307d73a250f8c7a7f2db2042a4"}

[commit-bot: I haz the power, 2017-04-07 21:58:41]

Description was changed from

==========
Reporting: Implement browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.

BUG=704259
==========

to

==========
Reporting: Implement browsing data remover.

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

The browsing data remover removes reports and/or endpoints that match
an (optional) origin filter, or all reports and/or endpoints. It will
be called from Chromium's browsing_data_remover, potentially among
other places.

BUG=704259

Review-Url: https://codereview.chromium.org/2752523005
Cr-Commit-Position: refs/heads/master@{#463016}
Committed:
https://chromium.googlesource.com/chromium/src/+/1170eb931001e6307d73a250f8c7...
==========

[commit-bot: I haz the power, 2017-04-07 21:58:42]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/1170eb931001e6307d73a250f8c7...