Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2752523002: Handle USB device disconnection during early setup. (Closed)

Created:
3 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
juncai
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle USB device disconnection during early setup. This patch fixes two issues which can occur when a device is closed while it is being configured. First, ensuring that if the Mojo pipe is closed while it is being opened that the device handle is closed before it is freed. Second, that if a device handle is closed while an interface claim is in progress the result is properly discarded. BUG=700191 Review-Url: https://codereview.chromium.org/2752523002 Cr-Commit-Position: refs/heads/master@{#456789} Committed: https://chromium.googlesource.com/chromium/src/+/2476b555727bb19508ae94feafa76dc6b9a69c1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M device/usb/mojo/device_impl.h View 1 chunk +3 lines, -2 lines 0 comments Download
M device/usb/mojo/device_impl.cc View 1 chunk +13 lines, -5 lines 0 comments Download
M device/usb/usb_device_handle_impl.cc View 4 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Reilly Grant (use Gerrit)
PTAL
3 years, 9 months ago (2017-03-13 22:51:48 UTC) #2
juncai
LGTM.
3 years, 9 months ago (2017-03-14 00:18:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752523002/1
3 years, 9 months ago (2017-03-14 01:20:33 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/407965)
3 years, 9 months ago (2017-03-14 02:11:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752523002/1
3 years, 9 months ago (2017-03-14 18:05:51 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 19:40:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2476b555727bb19508ae94feafa7...

Powered by Google App Engine
This is Rietveld 408576698