third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js - Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)

Patch Set: compilation errors Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js ('K') | « third_party/WebKit/Source/devtools/front_end/profiler/HeapProfilerPanel.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

index cad9b64187a517931e07e0a9528bae348cf8adc8..d723745d9e95498a8aacaaa924cf63ba8d95046d 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js

@@ -401,7 +401,7 @@ Profiler.WritableProfileHeader = class extends Profiler.ProfileHeader {

constructor(target, type, title) {

super(target, type, title || Common.UIString('Profile %d', type.nextProfileUid()));

- this._debuggerModel = SDK.DebuggerModel.fromTarget(target);

+ this._debuggerModel = target ? target.model(SDK.DebuggerModel) : null;

caseq 2017/03/17 18:30:43 nit: we typically prefer "target && target.model(S

dgozman 2017/03/17 21:43:46 Done.

this._tempFile = null;

}