Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 /** 371 /**
372 * @param {string} tokenType 372 * @param {string} tokenType
373 * @return {boolean} 373 * @return {boolean}
374 */ 374 */
375 _isIdentifier(tokenType) { 375 _isIdentifier(tokenType) {
376 return tokenType.startsWith('js-variable') || tokenType.startsWith('js-prope rty') || tokenType === 'js-def'; 376 return tokenType.startsWith('js-variable') || tokenType.startsWith('js-prope rty') || tokenType === 'js-def';
377 } 377 }
378 378
379 _getPopoverAnchor(element, event) { 379 _getPopoverAnchor(element, event) {
380 var target = UI.context.flavor(SDK.Target); 380 var target = UI.context.flavor(SDK.Target);
381 var debuggerModel = SDK.DebuggerModel.fromTarget(target); 381 var debuggerModel = target ? target.model(SDK.DebuggerModel) : null;
382 if (!debuggerModel || !debuggerModel.isPaused()) 382 if (!debuggerModel || !debuggerModel.isPaused())
383 return; 383 return;
384 384
385 var textPosition = this.textEditor.coordinatesToCursorPosition(event.x, even t.y); 385 var textPosition = this.textEditor.coordinatesToCursorPosition(event.x, even t.y);
386 if (!textPosition) 386 if (!textPosition)
387 return; 387 return;
388 var mouseLine = textPosition.startLine; 388 var mouseLine = textPosition.startLine;
389 var mouseColumn = textPosition.startColumn; 389 var mouseColumn = textPosition.startColumn;
390 var textSelection = this.textEditor.selection().normalize(); 390 var textSelection = this.textEditor.selection().normalize();
391 if (textSelection && !textSelection.isEmpty()) { 391 if (textSelection && !textSelection.isEmpty()) {
(...skipping 1112 matching lines...) Expand 10 before | Expand all | Expand 10 after
1504 return; 1504 return;
1505 this.bookmark.clear(); 1505 this.bookmark.clear();
1506 this.bookmark = null; 1506 this.bookmark = null;
1507 } 1507 }
1508 }; 1508 };
1509 1509
1510 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark'); 1510 Sources.JavaScriptSourceFrame.BreakpointDecoration.bookmarkSymbol = Symbol('book mark');
1511 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element'); 1511 Sources.JavaScriptSourceFrame.BreakpointDecoration._elementSymbolForTest = Symbo l('element');
1512 1512
1513 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark'); 1513 Sources.JavaScriptSourceFrame.continueToLocationDecorationSymbol = Symbol('bookm ark');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698