Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/main/OverlayController.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 */ 6 */
7 Main.OverlayController = class { 7 Main.OverlayController = class {
8 constructor() { 8 constructor() {
9 Common.moduleSetting('disablePausedStateOverlay').addChangeListener(this._up dateAllOverlays, this); 9 Common.moduleSetting('disablePausedStateOverlay').addChangeListener(this._up dateAllOverlays, this);
10 SDK.targetManager.addModelListener( 10 SDK.targetManager.addModelListener(
11 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this._update Overlay, this); 11 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerPaused, this._update Overlay, this);
12 SDK.targetManager.addModelListener( 12 SDK.targetManager.addModelListener(
13 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed, this._updat eOverlay, this); 13 SDK.DebuggerModel, SDK.DebuggerModel.Events.DebuggerResumed, this._updat eOverlay, this);
14 // TODO(dgozman): we should get DebuggerResumed on navigations instead of li stening to GlobalObjectCleared. 14 // TODO(dgozman): we should get DebuggerResumed on navigations instead of li stening to GlobalObjectCleared.
15 SDK.targetManager.addModelListener( 15 SDK.targetManager.addModelListener(
16 SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this._u pdateOverlay, this); 16 SDK.DebuggerModel, SDK.DebuggerModel.Events.GlobalObjectCleared, this._u pdateOverlay, this);
17 SDK.targetManager.addEventListener(SDK.TargetManager.Events.SuspendStateChan ged, this._updateAllOverlays, this); 17 SDK.targetManager.addEventListener(SDK.TargetManager.Events.SuspendStateChan ged, this._updateAllOverlays, this);
18 } 18 }
19 19
20 _updateAllOverlays() { 20 _updateAllOverlays() {
21 for (var target of SDK.targetManager.targets(SDK.Target.Capability.Browser)) { 21 for (var debuggerModel of SDK.targetManager.models(SDK.DebuggerModel))
22 this._updateTargetOverlay( 22 this._updateTargetOverlay(debuggerModel);
23 /** @type {!SDK.DebuggerModel} */ (SDK.DebuggerModel.fromTarget(target )));
24 }
25 } 23 }
26 24
27 /** 25 /**
28 * @param {!Common.Event} event 26 * @param {!Common.Event} event
29 */ 27 */
30 _updateOverlay(event) { 28 _updateOverlay(event) {
31 this._updateTargetOverlay(/** @type {!SDK.DebuggerModel} */ (event.data)); 29 this._updateTargetOverlay(/** @type {!SDK.DebuggerModel} */ (event.data));
32 } 30 }
33 31
34 /** 32 /**
35 * @param {!SDK.DebuggerModel} debuggerModel 33 * @param {!SDK.DebuggerModel} debuggerModel
36 */ 34 */
37 _updateTargetOverlay(debuggerModel) { 35 _updateTargetOverlay(debuggerModel) {
38 if (!debuggerModel.target().hasBrowserCapability()) 36 if (!debuggerModel.target().hasBrowserCapability())
39 return; 37 return;
40 var message = debuggerModel.isPaused() && !Common.moduleSetting('disablePaus edStateOverlay').get() ? 38 var message = debuggerModel.isPaused() && !Common.moduleSetting('disablePaus edStateOverlay').get() ?
41 Common.UIString('Paused in debugger') : 39 Common.UIString('Paused in debugger') :
42 undefined; 40 undefined;
43 debuggerModel.target().pageAgent().configureOverlay(SDK.targetManager.allTar getsSuspended(), message); 41 debuggerModel.target().pageAgent().configureOverlay(SDK.targetManager.allTar getsSuspended(), message);
44 } 42 }
45 }; 43 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698