Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/event_listeners/EventListenersUtils.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** @typedef {{eventListeners:!Array<!SDK.EventListener>, internalHandlers:?SDK. RemoteArray}} */ 4 /** @typedef {{eventListeners:!Array<!SDK.EventListener>, internalHandlers:?SDK. RemoteArray}} */
5 EventListeners.FrameworkEventListenersObject; 5 EventListeners.FrameworkEventListenersObject;
6 6
7 /** @typedef {{type: string, useCapture: boolean, passive: boolean, once: boolea n, handler: function()}} */ 7 /** @typedef {{type: string, useCapture: boolean, passive: boolean, once: boolea n, handler: function()}} */
8 EventListeners.EventListenerObjectInInspectedPage; 8 EventListeners.EventListenerObjectInInspectedPage;
9 9
10 /** 10 /**
11 * @param {!SDK.RemoteObject} object 11 * @param {!SDK.RemoteObject} object
12 * @return {!Promise<!EventListeners.FrameworkEventListenersObject>} 12 * @return {!Promise<!EventListeners.FrameworkEventListenersObject>}
13 */ 13 */
14 EventListeners.frameworkEventListeners = function(object) { 14 EventListeners.frameworkEventListeners = function(object) {
15 if (!object.target().hasDOMCapability()) { 15 if (!object.runtimeModel().target().hasDOMCapability()) {
16 // TODO(kozyatinskiy): figure out how this should work for |window|. 16 // TODO(kozyatinskiy): figure out how this should work for |window|.
17 return Promise.resolve( 17 return Promise.resolve(
18 /** @type {!EventListeners.FrameworkEventListenersObject} */ ({eventList eners: [], internalHandlers: null})); 18 /** @type {!EventListeners.FrameworkEventListenersObject} */ ({eventList eners: [], internalHandlers: null}));
19 } 19 }
20 20
21 var listenersResult = /** @type {!EventListeners.FrameworkEventListenersObject } */ ({eventListeners: []}); 21 var listenersResult = /** @type {!EventListeners.FrameworkEventListenersObject } */ ({eventListeners: []});
22 return object.callFunctionPromise(frameworkEventListeners, undefined) 22 return object.callFunctionPromise(frameworkEventListeners, undefined)
23 .then(assertCallFunctionResult) 23 .then(assertCallFunctionResult)
24 .then(getOwnProperties) 24 .then(getOwnProperties)
25 .then(createEventListeners) 25 .then(createEventListeners)
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 170
171 return Promise.all(promises).then(createEventListener).catchException(/** @type {?SDK.EventListener} */ (null)); 171 return Promise.all(promises).then(createEventListener).catchException(/** @type {?SDK.EventListener} */ (null));
172 172
173 /** 173 /**
174 * @return {!SDK.EventListener} 174 * @return {!SDK.EventListener}
175 */ 175 */
176 function createEventListener() { 176 function createEventListener() {
177 if (!location) 177 if (!location)
178 throw new Error('Empty event listener\'s location'); 178 throw new Error('Empty event listener\'s location');
179 return new SDK.EventListener( 179 return new SDK.EventListener(
180 handler._target, object, type, useCapture, passive, once, handler, o riginalHandler, location, 180 handler.runtimeModel(), object, type, useCapture, passive, once, han dler, originalHandler, location,
181 removeFunctionObject, SDK.EventListener.Origin.FrameworkUser); 181 removeFunctionObject, SDK.EventListener.Origin.FrameworkUser);
182 } 182 }
183 } 183 }
184 } 184 }
185 185
186 /** 186 /**
187 * @param {!SDK.RemoteObject} pageInternalHandlersObject 187 * @param {!SDK.RemoteObject} pageInternalHandlersObject
188 * @return {!Promise<!SDK.RemoteArray>} 188 * @return {!Promise<!SDK.RemoteArray>}
189 */ 189 */
190 function convertToInternalHandlers(pageInternalHandlersObject) { 190 function convertToInternalHandlers(pageInternalHandlersObject) {
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
474 return; 474 return;
475 var node = /** @type {!Node} */ (this); 475 var node = /** @type {!Node} */ (this);
476 var jQuery = /** @type {?{fn,data,_data}}*/ (window['jQuery']); 476 var jQuery = /** @type {?{fn,data,_data}}*/ (window['jQuery']);
477 if (!jQuery || !jQuery.fn) 477 if (!jQuery || !jQuery.fn)
478 return; 478 return;
479 var jQueryFunction = /** @type {function(!Node)} */ (jQuery); 479 var jQueryFunction = /** @type {function(!Node)} */ (jQuery);
480 jQueryFunction(node).off(type, selector, handler); 480 jQueryFunction(node).off(type, selector, handler);
481 } 481 }
482 } 482 }
483 }; 483 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698