Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1582 matching lines...) Expand 10 before | Expand all | Expand 10 after
1593 /** 1593 /**
1594 * @param {function(!Element)} resolve 1594 * @param {function(!Element)} resolve
1595 * @param {function(!Error)} reject 1595 * @param {function(!Error)} reject
1596 */ 1596 */
1597 function renderPromise(resolve, reject) { 1597 function renderPromise(resolve, reject) {
1598 if (object instanceof SDK.DOMNode) { 1598 if (object instanceof SDK.DOMNode) {
1599 onNodeResolved(/** @type {!SDK.DOMNode} */ (object)); 1599 onNodeResolved(/** @type {!SDK.DOMNode} */ (object));
1600 } else if (object instanceof SDK.DeferredDOMNode) { 1600 } else if (object instanceof SDK.DeferredDOMNode) {
1601 (/** @type {!SDK.DeferredDOMNode} */ (object)).resolve(onNodeResolved); 1601 (/** @type {!SDK.DeferredDOMNode} */ (object)).resolve(onNodeResolved);
1602 } else if (object instanceof SDK.RemoteObject) { 1602 } else if (object instanceof SDK.RemoteObject) {
1603 var domModel = SDK.DOMModel.fromTarget((/** @type {!SDK.RemoteObject} */ (object)).target()); 1603 var domModel = SDK.DOMModel.fromTarget((/** @type {!SDK.RemoteObject} */ (object)).runtimeModel().target());
1604 if (domModel) 1604 if (domModel)
1605 domModel.pushObjectAsNodeToFrontend(object, onNodeResolved); 1605 domModel.pushObjectAsNodeToFrontend(object, onNodeResolved);
1606 else 1606 else
1607 reject(new Error('No dom model for given JS object target found.')); 1607 reject(new Error('No dom model for given JS object target found.'));
1608 } else { 1608 } else {
1609 reject(new Error('Can\'t reveal not a node.')); 1609 reject(new Error('Can\'t reveal not a node.'));
1610 } 1610 }
1611 1611
1612 /** 1612 /**
1613 * @param {?SDK.DOMNode} node 1613 * @param {?SDK.DOMNode} node
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
1693 */ 1693 */
1694 function resolved(node) { 1694 function resolved(node) {
1695 if (node) { 1695 if (node) {
1696 this.treeOutline._selectedDOMNode = node; 1696 this.treeOutline._selectedDOMNode = node;
1697 this.treeOutline._selectedNodeChanged(); 1697 this.treeOutline._selectedNodeChanged();
1698 } 1698 }
1699 } 1699 }
1700 return true; 1700 return true;
1701 } 1701 }
1702 }; 1702 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698