Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com> 3 * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
4 * Copyright (C) 2009 Joseph Pecoraro 4 * Copyright (C) 2009 Joseph Pecoraro
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1010 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 /** 1021 /**
1022 * @param {function(undefined)} resolve 1022 * @param {function(undefined)} resolve
1023 * @param {function(!Error)} reject 1023 * @param {function(!Error)} reject
1024 */ 1024 */
1025 function revealPromise(resolve, reject) { 1025 function revealPromise(resolve, reject) {
1026 if (node instanceof SDK.DOMNode) { 1026 if (node instanceof SDK.DOMNode) {
1027 onNodeResolved(/** @type {!SDK.DOMNode} */ (node)); 1027 onNodeResolved(/** @type {!SDK.DOMNode} */ (node));
1028 } else if (node instanceof SDK.DeferredDOMNode) { 1028 } else if (node instanceof SDK.DeferredDOMNode) {
1029 (/** @type {!SDK.DeferredDOMNode} */ (node)).resolve(onNodeResolved); 1029 (/** @type {!SDK.DeferredDOMNode} */ (node)).resolve(onNodeResolved);
1030 } else if (node instanceof SDK.RemoteObject) { 1030 } else if (node instanceof SDK.RemoteObject) {
1031 var domModel = SDK.DOMModel.fromTarget(/** @type {!SDK.RemoteObject} */ (node).target()); 1031 var domModel = SDK.DOMModel.fromTarget(/** @type {!SDK.RemoteObject} */ (node).runtimeModel().target());
1032 if (domModel) 1032 if (domModel)
1033 domModel.pushObjectAsNodeToFrontend(node, onNodeResolved); 1033 domModel.pushObjectAsNodeToFrontend(node, onNodeResolved);
1034 else 1034 else
1035 reject(new Error('Could not resolve a node to reveal.')); 1035 reject(new Error('Could not resolve a node to reveal.'));
1036 } else { 1036 } else {
1037 reject(new Error('Can\'t reveal a non-node.')); 1037 reject(new Error('Can\'t reveal a non-node.'));
1038 panel._pendingNodeReveal = false; 1038 panel._pendingNodeReveal = false;
1039 } 1039 }
1040 1040
1041 /** 1041 /**
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
1112 * @param {!SDK.DOMNode} node 1112 * @param {!SDK.DOMNode} node
1113 * @return {?{title: string, color: string}} 1113 * @return {?{title: string, color: string}}
1114 */ 1114 */
1115 decorate(node) { 1115 decorate(node) {
1116 return { 1116 return {
1117 color: 'orange', 1117 color: 'orange',
1118 title: Common.UIString('Element state: %s', ':' + SDK.CSSModel.fromNode(no de).pseudoState(node).join(', :')) 1118 title: Common.UIString('Element state: %s', ':' + SDK.CSSModel.fromNode(no de).pseudoState(node).join(', :'))
1119 }; 1119 };
1120 } 1120 }
1121 }; 1121 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698