Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2009 Joseph Pecoraro 3 * Copyright (C) 2009 Joseph Pecoraro
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 783 matching lines...) Expand 10 before | Expand all | Expand 10 after
794 */ 794 */
795 _printResult(result, originatingConsoleMessage, exceptionDetails) { 795 _printResult(result, originatingConsoleMessage, exceptionDetails) {
796 if (!result) 796 if (!result)
797 return; 797 return;
798 798
799 var level = !!exceptionDetails ? ConsoleModel.ConsoleMessage.MessageLevel.Er ror : 799 var level = !!exceptionDetails ? ConsoleModel.ConsoleMessage.MessageLevel.Er ror :
800 ConsoleModel.ConsoleMessage.MessageLevel.In fo; 800 ConsoleModel.ConsoleMessage.MessageLevel.In fo;
801 var message; 801 var message;
802 if (!exceptionDetails) { 802 if (!exceptionDetails) {
803 message = new ConsoleModel.ConsoleMessage( 803 message = new ConsoleModel.ConsoleMessage(
804 result.target(), ConsoleModel.ConsoleMessage.MessageSource.JS, level, '', 804 result.runtimeModel().target(), ConsoleModel.ConsoleMessage.MessageSou rce.JS, level, '',
805 ConsoleModel.ConsoleMessage.MessageType.Result, undefined, undefined, undefined, undefined, [result]); 805 ConsoleModel.ConsoleMessage.MessageType.Result, undefined, undefined, undefined, undefined, [result]);
806 } else { 806 } else {
807 message = ConsoleModel.ConsoleMessage.fromException( 807 message = ConsoleModel.ConsoleMessage.fromException(
808 result.target(), exceptionDetails, ConsoleModel.ConsoleMessage.Message Type.Result, undefined, undefined); 808 result.runtimeModel(), exceptionDetails, ConsoleModel.ConsoleMessage.M essageType.Result, undefined,
809 undefined);
809 } 810 }
810 message.setOriginatingMessage(originatingConsoleMessage); 811 message.setOriginatingMessage(originatingConsoleMessage);
811 ConsoleModel.consoleModel.addMessage(message); 812 ConsoleModel.consoleModel.addMessage(message);
812 } 813 }
813 814
814 /** 815 /**
815 * @param {!Common.Event} event 816 * @param {!Common.Event} event
816 */ 817 */
817 _commandEvaluated(event) { 818 _commandEvaluated(event) {
818 var data = 819 var data =
(...skipping 502 matching lines...) Expand 10 before | Expand all | Expand 10 after
1321 return true; 1322 return true;
1322 } 1323 }
1323 return false; 1324 return false;
1324 } 1325 }
1325 }; 1326 };
1326 1327
1327 /** 1328 /**
1328 * @typedef {{messageIndex: number, matchIndex: number}} 1329 * @typedef {{messageIndex: number, matchIndex: number}}
1329 */ 1330 */
1330 Console.ConsoleView.RegexMatchRange; 1331 Console.ConsoleView.RegexMatchRange;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698