Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/DebuggerWorkspaceBinding.js

Issue 2752403002: [DevTools] Migrate usages of Target to RuntimeModel where makes sense (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @unrestricted 5 * @unrestricted
6 * @implements {SDK.SDKModelObserver<!SDK.DebuggerModel>} 6 * @implements {SDK.SDKModelObserver<!SDK.DebuggerModel>}
7 */ 7 */
8 Bindings.DebuggerWorkspaceBinding = class extends Common.Object { 8 Bindings.DebuggerWorkspaceBinding = class extends Common.Object {
9 /** 9 /**
10 * @param {!SDK.TargetManager} targetManager 10 * @param {!SDK.TargetManager} targetManager
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 } 193 }
194 194
195 /** 195 /**
196 * @param {!Workspace.UILocation} uiLocation 196 * @param {!Workspace.UILocation} uiLocation
197 * @return {!Workspace.UILocation} 197 * @return {!Workspace.UILocation}
198 */ 198 */
199 normalizeUILocation(uiLocation) { 199 normalizeUILocation(uiLocation) {
200 var target = Bindings.NetworkProject.targetForUISourceCode(uiLocation.uiSour ceCode); 200 var target = Bindings.NetworkProject.targetForUISourceCode(uiLocation.uiSour ceCode);
201 if (target) { 201 if (target) {
202 var rawLocation = this.uiLocationToRawLocation( 202 var rawLocation = this.uiLocationToRawLocation(
203 SDK.DebuggerModel.fromTarget(target), uiLocation.uiSourceCode, uiLocat ion.lineNumber, 203 target.model(SDK.DebuggerModel), uiLocation.uiSourceCode, uiLocation.l ineNumber, uiLocation.columnNumber);
204 uiLocation.columnNumber);
205 if (rawLocation) 204 if (rawLocation)
206 return this.rawLocationToUILocation(rawLocation); 205 return this.rawLocationToUILocation(rawLocation);
207 } 206 }
208 return uiLocation; 207 return uiLocation;
209 } 208 }
210 209
211 /** 210 /**
212 * @param {!Workspace.UISourceCode} uiSourceCode 211 * @param {!Workspace.UISourceCode} uiSourceCode
213 * @param {number} lineNumber 212 * @param {number} lineNumber
214 * @return {boolean} 213 * @return {boolean}
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
668 * @param {number} lineNumber 667 * @param {number} lineNumber
669 * @return {boolean} 668 * @return {boolean}
670 */ 669 */
671 uiLineHasMapping(uiSourceCode, lineNumber) {} 670 uiLineHasMapping(uiSourceCode, lineNumber) {}
672 }; 671 };
673 672
674 /** 673 /**
675 * @type {!Bindings.DebuggerWorkspaceBinding} 674 * @type {!Bindings.DebuggerWorkspaceBinding}
676 */ 675 */
677 Bindings.debuggerWorkspaceBinding; 676 Bindings.debuggerWorkspaceBinding;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698