[DevTools] Migrate usages of Target to RuntimeModel where makes sense

third_party/WebKit/Source/devtools/front_end/console_model/ConsoleModel.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 189 matching lines @@
     this.addMessage(consoleMessage);
   }
 
   /**
    * @param {!SDK.RuntimeModel} runtimeModel
    * @param {!Common.Event} event
    */
   _exceptionThrown(runtimeModel, event) {
     var exceptionWithTimestamp = /** @type {!SDK.RuntimeModel.ExceptionWithTimestamp} */ (event.data);
     var consoleMessage = ConsoleModel.ConsoleMessage.fromException(
-        runtimeModel.target(), exceptionWithTimestamp.details, undefined, exceptionWithTimestamp.timestamp, undefined);
+        runtimeModel, exceptionWithTimestamp.details, undefined, exceptionWithTimestamp.timestamp, undefined);
     consoleMessage.setExceptionId(exceptionWithTimestamp.details.exceptionId);
     this.addMessage(consoleMessage);
   }
 
   /**
    * @param {!SDK.RuntimeModel} runtimeModel
    * @param {!Common.Event} event
    */
   _exceptionRevoked(runtimeModel, event) {
     var exceptionId = /** @type {number} */ (event.data);
@@ skipping 233 matching lines @@
   /**
    * @param {!ConsoleModel.ConsoleMessage} a
    * @param {!ConsoleModel.ConsoleMessage} b
    * @return {number}
    */
   static timestampComparator(a, b) {
     return a.timestamp - b.timestamp;
   }
 
   /**
-   * @param {!SDK.Target} target
+   * @param {!SDK.RuntimeModel} runtimeModel

[caseq, 2017/03/17 18:30:43]

Meeh :( Perhaps keep target here?

[dgozman, 2017/03/17 21:43:46]

Since exception comes from a runtime, passing RuntimeModel is logical here.

    * @param {!Protocol.Runtime.ExceptionDetails} exceptionDetails
    * @param {string=} messageType
    * @param {number=} timestamp
    * @param {string=} forceUrl
    * @return {!ConsoleModel.ConsoleMessage}
    */
-  static fromException(target, exceptionDetails, messageType, timestamp, forceUrl) {
+  static fromException(runtimeModel, exceptionDetails, messageType, timestamp, forceUrl) {
     return new ConsoleModel.ConsoleMessage(
-        target, ConsoleModel.ConsoleMessage.MessageSource.JS, ConsoleModel.ConsoleMessage.MessageLevel.Error,
-        SDK.RuntimeModel.simpleTextFromException(exceptionDetails), messageType, forceUrl || exceptionDetails.url,
-        exceptionDetails.lineNumber, exceptionDetails.columnNumber, undefined,
+        runtimeModel.target(), ConsoleModel.ConsoleMessage.MessageSource.JS,
+        ConsoleModel.ConsoleMessage.MessageLevel.Error, SDK.RuntimeModel.simpleTextFromException(exceptionDetails),
+        messageType, forceUrl || exceptionDetails.url, exceptionDetails.lineNumber, exceptionDetails.columnNumber,
+        undefined,
         exceptionDetails.exception ?
             [SDK.RemoteObject.fromLocalObject(exceptionDetails.text), exceptionDetails.exception] :
             undefined,
         exceptionDetails.stackTrace, timestamp, exceptionDetails.executionContextId, exceptionDetails.scriptId);
   }
 
   /**
    * @return {?SDK.Target}
    */
   target() {
@@ skipping 179 matching lines @@
     return 2;
   return 3;
 };
 
 ConsoleModel.ConsoleModel._events = Symbol('ConsoleModel.ConsoleModel.events');
 
 /**
  * @type {!ConsoleModel.ConsoleModel}
  */
 ConsoleModel.consoleModel;