Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2752373003: MD Settings: Make Escape blur and undo changes to input fields. (Closed)

Created:
3 years, 9 months ago by tommycli
Modified:
3 years, 9 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Make Escape blur and undo changes to input fields. BUG=675395 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2752373003 Cr-Commit-Position: refs/heads/master@{#458089} Committed: https://chromium.googlesource.com/chromium/src/+/0537699620f2f47459e1a91e5c480f44fee08e77

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M chrome/browser/resources/settings/controls/settings_input.html View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/controls/settings_input.js View 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/manage_profile.js View 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
tommycli
dbeam: PTAL. Tried to add tests to settings-input, but MockInteractions has weakish support for keyboard ...
3 years, 9 months ago (2017-03-16 23:21:10 UTC) #3
Dan Beam
lgtm
3 years, 9 months ago (2017-03-17 01:43:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752373003/20001
3 years, 9 months ago (2017-03-20 15:36:50 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 16:42:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0537699620f2f47459e1a91e5c48...

Powered by Google App Engine
This is Rietveld 408576698