Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Issue 2752333002: DevTools: more efficiently dispose messages on console clear (Closed)

Created:
3 years, 9 months ago by luoe
Modified:
3 years, 9 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: more efficiently dispose messages on console clear When logging 100k errors in console and clearing, it can take 10sec in PresentationConsoleMessageHelper._consoleCleared(). This CL changes the function's logic and lets all relevant uiSourceCodes know about all messages to be removed, instead of removing one-by-one. BUG=651610 Review-Url: https://codereview.chromium.org/2752333002 Cr-Commit-Position: refs/heads/master@{#457951} Committed: https://chromium.googlesource.com/chromium/src/+/4aab7a540a5ce356f6ddd9455c9ac35b83315a29

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set instead of array #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js View 1 1 chunk +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
luoe
On my machine, clearing 100k errors now takes < 0.5 sec in _consoleCleared()! Please take ...
3 years, 9 months ago (2017-03-16 19:04:56 UTC) #2
lushnikov
https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js (right): https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js#newcode565 third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:565: if (this._messages && this._messages.remove(message)) let's rather have this._messages a ...
3 years, 9 months ago (2017-03-17 01:29:05 UTC) #3
luoe
Nice idea. Ptal https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js (right): https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js#newcode565 third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:565: if (this._messages && this._messages.remove(message)) On 2017/03/17 ...
3 years, 9 months ago (2017-03-17 18:33:00 UTC) #4
lushnikov
lgtm
3 years, 9 months ago (2017-03-18 00:29:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752333002/20001
3 years, 9 months ago (2017-03-18 01:17:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/386428)
3 years, 9 months ago (2017-03-18 02:30:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752333002/20001
3 years, 9 months ago (2017-03-18 02:44:02 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-18 03:38:57 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4aab7a540a5ce356f6ddd9455c9a...

Powered by Google App Engine
This is Rietveld 408576698