DevTools: more efficiently dispose messages on console clear

DevTools: more efficiently dispose messages on console clear

When logging 100k errors in console and clearing, it can take 10sec in
PresentationConsoleMessageHelper._consoleCleared(). This CL changes the
function's logic and lets all relevant uiSourceCodes know about all
messages to be removed, instead of removing one-by-one.

BUG=651610
Review-Url: https://codereview.chromium.org/2752333002
Cr-Commit-Position: refs/heads/master@{#457951}
Committed: https://chromium.googlesource.com/chromium/src/+/4aab7a540a5ce356f6ddd9455c9ac35b83315a29

[luoe, 2017-03-16 19:04:55]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2017-03-16 19:04:56]

On my machine, clearing 100k errors now takes < 0.5 sec in _consoleCleared()!

Please take a look

[lushnikov, 2017-03-17 01:29:05]

https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:565: if
(this._messages && this._messages.remove(message))
let's rather have this._messages a set

[luoe, 2017-03-17 18:33:00]

Nice idea.  Ptal

https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
(right):

https://codereview.chromium.org/2752333002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js:565: if
(this._messages && this._messages.remove(message))
On 2017/03/17 01:29:05, lushnikov wrote:
> let's rather have this._messages a set

Done.

[lushnikov, 2017-03-18 00:29:50]

lgtm

[luoe, 2017-03-18 01:17:08]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-03-18 01:17:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 02:30:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:30:32]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[luoe, 2017-03-18 02:43:26]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2017-03-18 02:44:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-18 03:37:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489805006967560,
"parent_rev": "ad1a6b723ffaab42cad83762acd1e9dca17a8fcd", "commit_rev":
"4aab7a540a5ce356f6ddd9455c9ac35b83315a29"}

[commit-bot: I haz the power, 2017-03-18 03:38:56]

Description was changed from

==========
DevTools: more efficiently dispose messages on console clear

When logging 100k errors in console and clearing, it can take 10sec in
PresentationConsoleMessageHelper._consoleCleared(). This CL changes the
function's logic and lets all relevant uiSourceCodes know about all
messages to be removed, instead of removing one-by-one.

BUG=651610
==========

to

==========
DevTools: more efficiently dispose messages on console clear

When logging 100k errors in console and clearing, it can take 10sec in
PresentationConsoleMessageHelper._consoleCleared(). This CL changes the
function's logic and lets all relevant uiSourceCodes know about all
messages to be removed, instead of removing one-by-one.

BUG=651610

Review-Url: https://codereview.chromium.org/2752333002
Cr-Commit-Position: refs/heads/master@{#457951}
Committed:
https://chromium.googlesource.com/chromium/src/+/4aab7a540a5ce356f6ddd9455c9a...
==========

[commit-bot: I haz the power, 2017-03-18 03:38:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4aab7a540a5ce356f6ddd9455c9a...