Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: media/test/pipeline_integration_test.cc

Issue 2752323002: Support Opus Ambisonics playback (Closed)
Patch Set: Fix issues from rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/test/pipeline_integration_test.cc
diff --git a/media/test/pipeline_integration_test.cc b/media/test/pipeline_integration_test.cc
index 331b9d38d5b912ee6362d139ff87251a40f86365..d2db03cb5b28708cea6843ba9a0a725d7e32fd91 100644
--- a/media/test/pipeline_integration_test.cc
+++ b/media/test/pipeline_integration_test.cc
@@ -566,6 +566,22 @@ TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg) {
ASSERT_TRUE(WaitUntilOnEnded());
}
+TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg_4ch_ChannelMapping2) {
DaleCurtis 2017/05/24 00:49:58 These can all be kClockless type tests I think?
flim-chromium 2017/05/25 00:04:26 We might want to use with audio controls that enab
DaleCurtis 2017/05/25 00:29:16 Hmmm? I don't understand what you're asking. I'm j
flim-chromium 2017/05/25 00:46:06 Oh, I thought that'd use ClocklessAudioSink and ma
DaleCurtis 2017/05/25 00:53:38 That will be used, but until these tests actually
flim-chromium 2017/05/25 02:16:41 Got it, will upload this fix later with any change
flim-chromium 2017/05/25 22:00:40 Done.
+ ASSERT_EQ(PIPELINE_OK, Start("bear-opus-4ch-channelmapping2.ogg"));
+
+ Play();
+
+ ASSERT_TRUE(WaitUntilOnEnded());
+}
+
+TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg_11ch_ChannelMapping2) {
+ ASSERT_EQ(PIPELINE_OK, Start("bear-opus-11ch-channelmapping2.ogg"));
+
+ Play();
+
+ ASSERT_TRUE(WaitUntilOnEnded());
+}
+
TEST_F(PipelineIntegrationTest, BasicPlaybackHashed) {
ASSERT_EQ(PIPELINE_OK, Start("bear-320x240.webm", kHashed));
@@ -2198,6 +2214,22 @@ TEST_F(PipelineIntegrationTest, BasicPlayback_AudioOnly_Opus_WebM) {
ASSERT_TRUE(WaitUntilOnEnded());
}
+TEST_F(PipelineIntegrationTest,
+ BasicPlayback_AudioOnly_Opus_4ch_ChannelMapping2_WebM) {
+ ASSERT_EQ(PIPELINE_OK,
+ Start("bear-opus-end-trimming-4ch-channelmapping2.webm"));
+ Play();
+ ASSERT_TRUE(WaitUntilOnEnded());
+}
+
+TEST_F(PipelineIntegrationTest,
+ BasicPlayback_AudioOnly_Opus_11ch_ChannelMapping2_WebM) {
+ ASSERT_EQ(PIPELINE_OK,
+ Start("bear-opus-end-trimming-11ch-channelmapping2.webm"));
+ Play();
+ ASSERT_TRUE(WaitUntilOnEnded());
+}
+
// Verify that VP9 video in WebM containers can be played back.
TEST_F(PipelineIntegrationTest, BasicPlayback_VideoOnly_VP9_WebM) {
ASSERT_EQ(PIPELINE_OK, Start("bear-vp9.webm"));

Powered by Google App Engine
This is Rietveld 408576698