Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: media/test/pipeline_integration_test.cc

Issue 2752323002: Support Opus Ambisonics playback (Closed)
Patch Set: Fix issues from rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <memory> 8 #include <memory>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 } 559 }
560 560
561 TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg) { 561 TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg) {
562 ASSERT_EQ(PIPELINE_OK, Start("bear-opus.ogg")); 562 ASSERT_EQ(PIPELINE_OK, Start("bear-opus.ogg"));
563 563
564 Play(); 564 Play();
565 565
566 ASSERT_TRUE(WaitUntilOnEnded()); 566 ASSERT_TRUE(WaitUntilOnEnded());
567 } 567 }
568 568
569 TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg_4ch_ChannelMapping2) {
DaleCurtis 2017/05/24 00:49:58 These can all be kClockless type tests I think?
flim-chromium 2017/05/25 00:04:26 We might want to use with audio controls that enab
DaleCurtis 2017/05/25 00:29:16 Hmmm? I don't understand what you're asking. I'm j
flim-chromium 2017/05/25 00:46:06 Oh, I thought that'd use ClocklessAudioSink and ma
DaleCurtis 2017/05/25 00:53:38 That will be used, but until these tests actually
flim-chromium 2017/05/25 02:16:41 Got it, will upload this fix later with any change
flim-chromium 2017/05/25 22:00:40 Done.
570 ASSERT_EQ(PIPELINE_OK, Start("bear-opus-4ch-channelmapping2.ogg"));
571
572 Play();
573
574 ASSERT_TRUE(WaitUntilOnEnded());
575 }
576
577 TEST_F(PipelineIntegrationTest, BasicPlaybackOpusOgg_11ch_ChannelMapping2) {
578 ASSERT_EQ(PIPELINE_OK, Start("bear-opus-11ch-channelmapping2.ogg"));
579
580 Play();
581
582 ASSERT_TRUE(WaitUntilOnEnded());
583 }
584
569 TEST_F(PipelineIntegrationTest, BasicPlaybackHashed) { 585 TEST_F(PipelineIntegrationTest, BasicPlaybackHashed) {
570 ASSERT_EQ(PIPELINE_OK, Start("bear-320x240.webm", kHashed)); 586 ASSERT_EQ(PIPELINE_OK, Start("bear-320x240.webm", kHashed));
571 587
572 Play(); 588 Play();
573 589
574 ASSERT_TRUE(WaitUntilOnEnded()); 590 ASSERT_TRUE(WaitUntilOnEnded());
575 591
576 EXPECT_HASH_EQ("f0be120a90a811506777c99a2cdf7cc1", GetVideoHash()); 592 EXPECT_HASH_EQ("f0be120a90a811506777c99a2cdf7cc1", GetVideoHash());
577 EXPECT_HASH_EQ("-3.59,-2.06,-0.43,2.15,0.77,-0.95,", GetAudioHash()); 593 EXPECT_HASH_EQ("-3.59,-2.06,-0.43,2.15,0.77,-0.95,", GetAudioHash());
578 EXPECT_TRUE(demuxer_->GetTimelineOffset().is_null()); 594 EXPECT_TRUE(demuxer_->GetTimelineOffset().is_null());
(...skipping 1612 matching lines...) Expand 10 before | Expand all | Expand 10 after
2191 0x1C896, 65536)); 2207 0x1C896, 65536));
2192 } 2208 }
2193 2209
2194 // Verify that Opus audio in WebM containers can be played back. 2210 // Verify that Opus audio in WebM containers can be played back.
2195 TEST_F(PipelineIntegrationTest, BasicPlayback_AudioOnly_Opus_WebM) { 2211 TEST_F(PipelineIntegrationTest, BasicPlayback_AudioOnly_Opus_WebM) {
2196 ASSERT_EQ(PIPELINE_OK, Start("bear-opus-end-trimming.webm")); 2212 ASSERT_EQ(PIPELINE_OK, Start("bear-opus-end-trimming.webm"));
2197 Play(); 2213 Play();
2198 ASSERT_TRUE(WaitUntilOnEnded()); 2214 ASSERT_TRUE(WaitUntilOnEnded());
2199 } 2215 }
2200 2216
2217 TEST_F(PipelineIntegrationTest,
2218 BasicPlayback_AudioOnly_Opus_4ch_ChannelMapping2_WebM) {
2219 ASSERT_EQ(PIPELINE_OK,
2220 Start("bear-opus-end-trimming-4ch-channelmapping2.webm"));
2221 Play();
2222 ASSERT_TRUE(WaitUntilOnEnded());
2223 }
2224
2225 TEST_F(PipelineIntegrationTest,
2226 BasicPlayback_AudioOnly_Opus_11ch_ChannelMapping2_WebM) {
2227 ASSERT_EQ(PIPELINE_OK,
2228 Start("bear-opus-end-trimming-11ch-channelmapping2.webm"));
2229 Play();
2230 ASSERT_TRUE(WaitUntilOnEnded());
2231 }
2232
2201 // Verify that VP9 video in WebM containers can be played back. 2233 // Verify that VP9 video in WebM containers can be played back.
2202 TEST_F(PipelineIntegrationTest, BasicPlayback_VideoOnly_VP9_WebM) { 2234 TEST_F(PipelineIntegrationTest, BasicPlayback_VideoOnly_VP9_WebM) {
2203 ASSERT_EQ(PIPELINE_OK, Start("bear-vp9.webm")); 2235 ASSERT_EQ(PIPELINE_OK, Start("bear-vp9.webm"));
2204 Play(); 2236 Play();
2205 ASSERT_TRUE(WaitUntilOnEnded()); 2237 ASSERT_TRUE(WaitUntilOnEnded());
2206 } 2238 }
2207 2239
2208 // Verify that VP9 video and Opus audio in the same WebM container can be played 2240 // Verify that VP9 video and Opus audio in the same WebM container can be played
2209 // back. 2241 // back.
2210 TEST_F(PipelineIntegrationTest, BasicPlayback_VP9_Opus_WebM) { 2242 TEST_F(PipelineIntegrationTest, BasicPlayback_VP9_Opus_WebM) {
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
2358 2390
2359 TEST_F(PipelineIntegrationTest, BasicPlaybackPositiveStartTime) { 2391 TEST_F(PipelineIntegrationTest, BasicPlaybackPositiveStartTime) {
2360 ASSERT_EQ(PIPELINE_OK, Start("nonzero-start-time.webm")); 2392 ASSERT_EQ(PIPELINE_OK, Start("nonzero-start-time.webm"));
2361 Play(); 2393 Play();
2362 ASSERT_TRUE(WaitUntilOnEnded()); 2394 ASSERT_TRUE(WaitUntilOnEnded());
2363 ASSERT_EQ(base::TimeDelta::FromMicroseconds(396000), 2395 ASSERT_EQ(base::TimeDelta::FromMicroseconds(396000),
2364 demuxer_->GetStartTime()); 2396 demuxer_->GetStartTime());
2365 } 2397 }
2366 2398
2367 } // namespace media 2399 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698