Read onDistanceChange events from Nearby Messages

Read onDistanceChange events from Nearby Messages

This change uses the new onDistanceChange events from Nearby Messages.
Additionally, we move our code out of PhysicalWebBleClient since there
is no longer a need for downstream code to override it.

BUG=702278
Review-Url: https://codereview.chromium.org/2752313003
Cr-Commit-Position: refs/heads/master@{#459219}
Committed: https://chromium.googlesource.com/chromium/src/+/5449aeb35dda45e9eb037bafd8ef50fb9c47fa95

[cco3, 2017-03-16 18:11:10]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[cco3, 2017-03-16 18:11:10]

Another one for you, Matt.

[mattreynolds, 2017-03-16 19:53:47]

lgtm

[cco3, 2017-03-16 20:07:10]

cco3@chromium.org changed reviewers:
+ nyquist@chromium.org

[cco3, 2017-03-16 20:07:11]

Hi Tommy, this is one of two changes upstreaming some code.  (There will be two
matching downstream changes afterward.)

[nyquist, 2017-03-22 16:55:00]

https://codereview.chromium.org/2752313003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java
(right):

https://codereview.chromium.org/2752313003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java:34:
public void onDistanceChanged(final Message message, final Distance distance) {
Nit: Doesn't look like message needs to be final?

https://codereview.chromium.org/2752313003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java:38:
new Handler(Looper.getMainLooper()).post(new Runnable() {
Why do you need a new handler? Can you instead just do:
ThreadUtils.postOnUiThread(new Runnable() { ... })?

[cco3, 2017-03-23 18:03:06]

https://codereview.chromium.org/2752313003/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java
(right):

https://codereview.chromium.org/2752313003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java:34:
public void onDistanceChanged(final Message message, final Distance distance) {
On 2017/03/22 16:55:00, nyquist wrote:
> Nit: Doesn't look like message needs to be final?

Done.

https://codereview.chromium.org/2752313003/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java:38:
new Handler(Looper.getMainLooper()).post(new Runnable() {
On 2017/03/22 16:55:00, nyquist wrote:
> Why do you need a new handler? Can you instead just do:
> ThreadUtils.postOnUiThread(new Runnable() { ... })?

Done.

[nyquist, 2017-03-23 20:06:11]

lgtm

[cco3, 2017-03-23 20:17:27]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-03-23 20:17:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
mattreynolds@chromium.org
Link to the patchset: https://codereview.chromium.org/2752313003/#ps80001
(title: "Use ThreadUtils")

[commit-bot: I haz the power, 2017-03-23 20:17:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 21:13:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1490300247316060,
"parent_rev": "a509c1856e45373776d372e64b59b029e014071f", "commit_rev":
"5449aeb35dda45e9eb037bafd8ef50fb9c47fa95"}

[commit-bot: I haz the power, 2017-03-23 21:14:00]

Description was changed from

==========
Read onDistanceChange events from Nearby Messages

This change uses the new onDistanceChange events from Nearby Messages.
Additionally, we move our code out of PhysicalWebBleClient since there
is no longer a need for downstream code to override it.

BUG=702278
==========

to

==========
Read onDistanceChange events from Nearby Messages

This change uses the new onDistanceChange events from Nearby Messages.
Additionally, we move our code out of PhysicalWebBleClient since there
is no longer a need for downstream code to override it.

BUG=702278

Review-Url: https://codereview.chromium.org/2752313003
Cr-Commit-Position: refs/heads/master@{#459219}
Committed:
https://chromium.googlesource.com/chromium/src/+/5449aeb35dda45e9eb037bafd8ef...
==========

[commit-bot: I haz the power, 2017-03-23 21:14:01]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5449aeb35dda45e9eb037bafd8ef...