views/mus: Install a mus-friend ContextFactory for tests.

views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in compositor which can
be used from aura, views, and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2752303002
Cr-Commit-Position: refs/heads/master@{#457865}
Committed: https://chromium.googlesource.com/chromium/src/+/19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1

[sadrul, 2017-03-16 17:12:13]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 17:12:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 17:19:20]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sadrul, 2017-03-16 17:40:47]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 17:41:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-16 17:44:38]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 17:44:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-16 17:46:59]

Description was changed from

==========
views/mus: Install a mus-friend ContextFactory for tests.

...

BUG=...
==========

to

==========
views/mus: Install a mus-friendly ContextFactory for tests.

...

BUG=618136
==========

[commit-bot: I haz the power, 2017-03-16 18:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 18:46:25]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-16 23:48:59]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 23:49:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 00:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 00:58:18]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-17 01:04:21]

Description was changed from

==========
views/mus: Install a mus-friendly ContextFactory for tests.

...

BUG=618136
==========

to

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in aura which can be
used from views and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
==========

[sadrul, 2017-03-17 01:05:05]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 01:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 02:07:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 02:07:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-03-17 02:34:04]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 02:34:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-17 03:39:07]

sadrul@chromium.org changed reviewers:
+ danakj@chromium.org, sky@chromium.org

[sadrul, 2017-03-17 03:39:08]

danakj@ for +cc DEPS from ui/aura/test/mus

sky@ for all of it.

Thanks!

[commit-bot: I haz the power, 2017-03-17 03:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 03:49:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2017-03-17 14:05:59]

Why not use cc/test/ FakeCompositorFrameSink?

[danakj, 2017-03-17 14:06:30]

On 2017/03/17 14:05:59, danakj wrote:
> Why not use cc/test/ FakeCompositorFrameSink?

Wait, nvm this is ContextFactory.. maybe there is one in ui/compositor/test you
can use?

[danakj, 2017-03-17 14:10:57]

oook I understand everything now. ui/compositor/test has one for pixel tests but
not a fake one. Can we do this:

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
File ui/aura/test/mus/test_context_factory.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.cc:19: class FakeCompositorFrameSink :
public cc::FakeCompositorFrameSink {
Can this be cc/test/'s FakeCompositorFrameSink?

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.cc:49: void
TestContextFactory::CreateCompositorFrameSink(
Can you put this in ui/compositor/test/ so we don't duplicate this into more
components and name it FakeContextFactory? "Test" isn't a prefix with meaning.
Fake/Mock/Stub have meanings.

[sadrul, 2017-03-17 15:31:11]

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
File ui/aura/test/mus/test_context_factory.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.cc:19: class FakeCompositorFrameSink :
public cc::FakeCompositorFrameSink {
On 2017/03/17 14:10:57, danakj wrote:
> Can this be cc/test/'s FakeCompositorFrameSink?

cc/test's FakeCompositorFrameSink does not install a BFS. That's why I have this
subclass. Should just update cc/tests's FakeCompositorFrameSink?

[danakj, 2017-03-17 15:33:14]

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
File ui/aura/test/mus/test_context_factory.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.cc:19: class FakeCompositorFrameSink :
public cc::FakeCompositorFrameSink {
On 2017/03/17 15:31:11, sadrul wrote:
> On 2017/03/17 14:10:57, danakj wrote:
> > Can this be cc/test/'s FakeCompositorFrameSink?
> 
> cc/test's FakeCompositorFrameSink does not install a BFS. That's why I have
this
> subclass. Should just update cc/tests's FakeCompositorFrameSink?

Ya sure! My high level theology here is that one fake class > many fakes all
over the codebase. And add to it to fit ur needs as u go, then other tests can
benefit from those too in the future.

[Fady Samuel, 2017-03-17 15:37:27]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2017-03-17 15:37:28]

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
File mash/test/mash_test_suite.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
mash/test/mash_test_suite.cc:88: // Some tests in ash use the
ContextFactoryPrivate (e.g.
nit: Add a TODO to not depend on ContextFactoryPrivate at all here?

[sky, 2017-03-17 15:48:16]

LGTM

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
File mash/test/mash_test_suite.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
mash/test/mash_test_suite.cc:27: class TestContextFactoryPrivate : public
ui::ContextFactoryPrivate {
How come mash needs this code, but not other tests?

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
File ui/aura/test/mus/test_context_factory.h (right):

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.h:23: class TestContextFactory : public
ui::ContextFactory {
Please add a description of this.

[sadrul, 2017-03-17 16:18:36]

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
File mash/test/mash_test_suite.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
mash/test/mash_test_suite.cc:27: class TestContextFactoryPrivate : public
ui::ContextFactoryPrivate {
On 2017/03/17 15:48:16, sky wrote:
> How come mash needs this code, but not other tests?

I had added a comment below where this is used. Some tests in ash (actually,
just two tests) currently needs this. Instead of having this, I think I am going
to just remove this, and disable those two tests in mash-mode instead.

[sadrul, 2017-03-17 16:42:06]

Description was changed from

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in aura which can be
used from views and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
==========

to

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in aura which can be
used from views and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sadrul, 2017-03-17 16:42:09]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 16:42:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-03-17 16:43:43]

SLGTM

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
File mash/test/mash_test_suite.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
mash/test/mash_test_suite.cc:27: class TestContextFactoryPrivate : public
ui::ContextFactoryPrivate {
On 2017/03/17 16:18:35, sadrul wrote:
> On 2017/03/17 15:48:16, sky wrote:
> > How come mash needs this code, but not other tests?
> 
> I had added a comment below where this is used. Some tests in ash (actually,
> just two tests) currently needs this. Instead of having this, I think I am
going
> to just remove this, and disable those two tests in mash-mode instead.

SGTM

[commit-bot: I haz the power, 2017-03-17 16:47:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:47:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-03-17 16:48:44]

Description was changed from

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in aura which can be
used from views and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
==========

to

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in aura which can be
used from views and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sadrul, 2017-03-17 16:48:47]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 16:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-17 16:50:29]

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
File mash/test/mash_test_suite.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/mash/test/mash_test_su...
mash/test/mash_test_suite.cc:88: // Some tests in ash use the
ContextFactoryPrivate (e.g.
On 2017/03/17 15:37:28, Fady Samuel wrote:
> nit: Add a TODO to not depend on ContextFactoryPrivate at all here?

Just removed the dep instead.

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
File ui/aura/test/mus/test_context_factory.cc (right):

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.cc:19: class FakeCompositorFrameSink :
public cc::FakeCompositorFrameSink {
On 2017/03/17 15:33:14, danakj wrote:
> On 2017/03/17 15:31:11, sadrul wrote:
> > On 2017/03/17 14:10:57, danakj wrote:
> > > Can this be cc/test/'s FakeCompositorFrameSink?
> > 
> > cc/test's FakeCompositorFrameSink does not install a BFS. That's why I have
> this
> > subclass. Should just update cc/tests's FakeCompositorFrameSink?
> 
> Ya sure! My high level theology here is that one fake class > many fakes all
> over the codebase. And add to it to fit ur needs as u go, then other tests can
> benefit from those too in the future.

Done.

https://codereview.chromium.org/2752303002/diff/100001/ui/aura/test/mus/test_...
ui/aura/test/mus/test_context_factory.cc:49: void
TestContextFactory::CreateCompositorFrameSink(
On 2017/03/17 14:10:57, danakj wrote:
> Can you put this in ui/compositor/test/ so we don't duplicate this into more
> components and name it FakeContextFactory? "Test" isn't a prefix with meaning.
> Fake/Mock/Stub have meanings.

Done.

[sadrul, 2017-03-17 16:51:29]

Description was changed from

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in aura which can be
used from views and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in compositor which can
be used from aura, views, and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[danakj, 2017-03-17 16:54:31]

ui/compositor and cc/ LGTM!

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
File ui/compositor/test/fake_context_factory.cc (right):

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
ui/compositor/test/fake_context_factory.cc:53: void
FakeContextFactory::AddObserver(ui::ContextFactoryObserver* observer) {}
(you can leave the defn of empty methods in the header if u want. this is fine
too)

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
File ui/compositor/test/fake_context_factory.h (right):

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
ui/compositor/test/fake_context_factory.h:29: // ui::ContextFactory::
I think you meant ui::ContextFactory:, though I prefer "ui::ContextFactory
implementation." but either way not the scope operator :)

[commit-bot: I haz the power, 2017-03-17 18:08:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:08:02]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-17 18:58:54]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-03-17 18:59:14]

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
File ui/compositor/test/fake_context_factory.cc (right):

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
ui/compositor/test/fake_context_factory.cc:53: void
FakeContextFactory::AddObserver(ui::ContextFactoryObserver* observer) {}
On 2017/03/17 16:54:31, danakj wrote:
> (you can leave the defn of empty methods in the header if u want. this is fine
> too)

Done.

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
File ui/compositor/test/fake_context_factory.h (right):

https://codereview.chromium.org/2752303002/diff/140001/ui/compositor/test/fak...
ui/compositor/test/fake_context_factory.h:29: // ui::ContextFactory::
On 2017/03/17 16:54:31, danakj wrote:
> I think you meant ui::ContextFactory:, though I prefer "ui::ContextFactory
> implementation." but either way not the scope operator :)

Whoops. Done!

[commit-bot: I haz the power, 2017-03-17 18:59:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-03-17 19:47:20]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2017-03-17 19:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2752303002/#ps160001
(title: ".")

[commit-bot: I haz the power, 2017-03-17 19:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 19:57:55]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1489780040040060,
"parent_rev": "daf68b54da7b10f5fb4ede59ba679adc748ac703", "commit_rev":
"19bc819e7192b19cd060a1f36c6d76ae0c9c9bf1"}

[commit-bot: I haz the power, 2017-03-17 19:58:41]

Description was changed from

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in compositor which can
be used from aura, views, and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
views/mus: Install a mus-friendly ContextFactory for tests.

A test running with aura-mus (in aura, views, or ash) does not need a
ui::ContextFactoryPrivate instance. It only needs a ui::ContextFactory.
ui::InProcessContextFactory is not the right implementation to use in a
mus client though, since it directly deals with cc::SurfaceManager,
cc::Display etc., which are not suitable for a mus client. So provide a
simpler implementation of ContextFactory instead in compositor which can
be used from aura, views, and ash.

Use this new ContextFactory for views_mus_unittests and mash_unittests.
This fixes using ui::DrawWaiterForTest in these tests.

BUG=618136
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2752303002
Cr-Commit-Position: refs/heads/master@{#457865}
Committed:
https://chromium.googlesource.com/chromium/src/+/19bc819e7192b19cd060a1f36c6d...
==========

[commit-bot: I haz the power, 2017-03-17 19:58:43]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/19bc819e7192b19cd060a1f36c6d...