[builtins] Implement Array.prototype.reduce in the CSA

[builtins] Implement Array.prototype.reduce in the CSA

BUG=v8:1956
Review-Url: https://codereview.chromium.org/2752273003
Cr-Commit-Position: refs/heads/master@{#43987}
Committed: https://chromium.googlesource.com/v8/v8/+/176a43fb86cc5b1f75751fc5b8011d0d77f84eb1

[danno, 2017-03-16 18:00:57]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 18:01:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 18:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 18:18:36]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[danno, 2017-03-16 21:08:36]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 21:08:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 21:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 21:33:08]

Dry run: This issue passed the CQ dry run.

[danno, 2017-03-17 10:18:12]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 10:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-03-17 10:18:46]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 10:18:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-03-17 10:26:30]

danno@chromium.org changed reviewers:
+ cbruni@chromium.org, ishell@chromium.org

[danno, 2017-03-17 10:26:31]

ptal

https://codereview.chromium.org/2752273003/diff/80001/src/builtins/builtins-a...
File src/builtins/builtins-array-gen.cc (right):

https://codereview.chromium.org/2752273003/diff/80001/src/builtins/builtins-a...
src/builtins/builtins-array-gen.cc:17: typedef std::function<std::pair<Node*,
Node*>(
Per Camillo's comments, I am going to add comments there to explain the
arguments and make them a little more useful, the names are taken from the spec
and that makes it a little hard to reason about in the code.

[commit-bot: I haz the power, 2017-03-17 10:42:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:43:00]

Dry run: This issue passed the CQ dry run.

[danno, 2017-03-20 10:58:48]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 10:58:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 11:00:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 11:00:23]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22866)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37089)

[danno, 2017-03-20 11:39:50]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 11:39:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 11:43:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 11:43:30]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22868)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/22782)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)

[danno, 2017-03-20 12:40:29]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 12:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 12:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 12:42:09]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22877)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/37103)

[danno, 2017-03-20 13:12:27]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 13:12:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 13:16:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 13:16:12]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/22885)

[danno, 2017-03-20 13:38:49]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 13:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 14:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 14:12:03]

Dry run: This issue passed the CQ dry run.

[danno, 2017-03-20 15:56:38]

Description was changed from

==========
[builtins] Implement Array.prototype.reduce in the CSA

BUG=v8:1956
==========

to

==========
[builtins] Implement Array.prototype.reduce in the CSA

BUG=v8:1956
==========

[danno, 2017-03-20 15:56:39]

danno@chromium.org changed reviewers:
+ mvstanton@chromium.org

[danno, 2017-03-21 10:48:11]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 10:48:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-03-21 10:49:53]

updated. please take another look?

[commit-bot: I haz the power, 2017-03-21 11:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 11:13:31]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-03-21 11:37:26]

lgtm

[Yang, 2017-03-21 11:47:03]

On 2017/03/21 11:37:26, mvstanton wrote:
> lgtm

src/debug lgtm.

[danno, 2017-03-21 11:52:20]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 11:52:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 13:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 13:10:35]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2017-03-21 14:20:28]

lgtm

https://codereview.chromium.org/2752273003/diff/260001/src/builtins/builtins-...
File src/builtins/builtins-array-gen.cc (right):

https://codereview.chromium.org/2752273003/diff/260001/src/builtins/builtins-...
src/builtins/builtins-array-gen.cc:618:
CodeFactory::ArrayForEachLoopContinuation(isolate()));
FYI: We have a Builtins::CallableFor(), so there's no need to add new stuff to
CodeFactory.

[danno, 2017-03-21 15:55:30]

Thanks for the review. Landing.

https://codereview.chromium.org/2752273003/diff/260001/src/builtins/builtins-...
File src/builtins/builtins-array-gen.cc (right):

https://codereview.chromium.org/2752273003/diff/260001/src/builtins/builtins-...
src/builtins/builtins-array-gen.cc:618:
CodeFactory::ArrayForEachLoopContinuation(isolate()));
On 2017/03/21 14:20:28, Igor Sheludko wrote:
> FYI: We have a Builtins::CallableFor(), so there's no need to add new stuff to
> CodeFactory.

To land quickly, will do this in a follow-on CL.

[danno, 2017-03-21 15:55:38]

The CQ bit was checked by danno@chromium.org

[danno, 2017-03-21 15:55:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2752273003/#ps260001
(title: "Simplify")

[commit-bot: I haz the power, 2017-03-21 15:55:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 15:57:39]

CQ is committing da patch.

Bot data: {"patchset_id": 260001, "attempt_start_ts": 1490111738113870,
"parent_rev": "64ffea8509ebf3e3a004a25ab3fbfbb8c106700b", "commit_rev":
"176a43fb86cc5b1f75751fc5b8011d0d77f84eb1"}

[commit-bot: I haz the power, 2017-03-21 15:57:44]

Description was changed from

==========
[builtins] Implement Array.prototype.reduce in the CSA

BUG=v8:1956
==========

to

==========
[builtins] Implement Array.prototype.reduce in the CSA

BUG=v8:1956

Review-Url: https://codereview.chromium.org/2752273003
Cr-Commit-Position: refs/heads/master@{#43987}
Committed:
https://chromium.googlesource.com/v8/v8/+/176a43fb86cc5b1f75751fc5b8011d0d77f...
==========

[commit-bot: I haz the power, 2017-03-21 15:57:46]

Committed patchset #14 (id:260001) as
https://chromium.googlesource.com/v8/v8/+/176a43fb86cc5b1f75751fc5b8011d0d77f...