Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2752273002: Replace v8 benchmark names with rawstring (Closed)
Patch Set: Remove left over TEST_SUFFIX Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8_browsing.py
diff --git a/tools/perf/benchmarks/v8_browsing.py b/tools/perf/benchmarks/v8_browsing.py
index 5c026a0fe45a638db68011b8867714fc834beedd..8cf4829922cfd386f64bbdce95ec3ed4b1f7fee5 100644
--- a/tools/perf/benchmarks/v8_browsing.py
+++ b/tools/perf/benchmarks/v8_browsing.py
@@ -68,10 +68,6 @@ class _V8BrowsingBenchmark(perf_benchmark.PerfBenchmark):
return page_sets.SystemHealthStorySet(platform=self.PLATFORM, case='browse')
@classmethod
- def Name(cls):
- return 'v8.browsing_%s%s' % (cls.PLATFORM, cls.TEST_SUFFIX)
-
- @classmethod
def ValueCanBeAddedPredicate(cls, value, is_first_result):
# TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
# is able to cope with the data load generated by TBMv2 metrics.
@@ -129,10 +125,6 @@ class _V8RuntimeStatsBrowsingBenchmark(perf_benchmark.PerfBenchmark):
return page_sets.SystemHealthStorySet(platform=self.PLATFORM, case='browse')
@classmethod
- def Name(cls):
- return 'v8.runtimestats.browsing_%s%s' % (cls.PLATFORM, cls.TEST_SUFFIX)
-
- @classmethod
def ShouldTearDownStateAfterEachStoryRun(cls):
return True
@@ -159,14 +151,20 @@ class _V8MobileBrowsingBenchmark(_V8BrowsingBenchmark):
@benchmark.Owner(emails=['ulan@chromium.org'])
class V8DesktopBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
PLATFORM = 'desktop'
- TEST_SUFFIX = ''
+
+ @classmethod
+ def Name(cls):
+ return 'v8.browsing_desktop'
@benchmark.Owner(emails=['ulan@chromium.org'])
@benchmark.Disabled('reference') # http://crbug.com/628631
class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark):
PLATFORM = 'mobile'
- TEST_SUFFIX = ''
+
+ @classmethod
+ def Name(cls):
+ return 'v8.browsing_mobile'
@benchmark.Disabled('reference') # http://crbug.com/700390
@@ -174,61 +172,77 @@ class V8MobileBrowsingBenchmark(_V8MobileBrowsingBenchmark):
@benchmark.Owner(emails=['mvstaton@chromium.org'])
class V8DesktopTurboBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
PLATFORM = 'desktop'
- TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8DesktopTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableTurbo(options)
+ @classmethod
+ def Name(cls):
+ return 'v8.browsing_desktop_turbo'
+
+
@benchmark.Disabled('reference') # http://crbug.com/628631
@benchmark.Disabled('all')
@benchmark.Owner(emails=['mvstaton@chromium.org'])
class V8MobileTurboBrowsingBenchmark(_V8MobileBrowsingBenchmark):
PLATFORM = 'mobile'
- TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8MobileTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableTurbo(options)
+ @classmethod
+ def Name(cls):
+ return 'v8.browsing_mobile_turbo'
+
@benchmark.Disabled('reference') # http://crbug.com/700390
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8DesktopClassicBrowsingBenchmark(_V8DesktopBrowsingBenchmark):
PLATFORM = 'desktop'
- TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8DesktopClassicBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableClassic(options)
+ @classmethod
+ def Name(cls):
+ return 'v8.browsing_desktop_classic'
+
@benchmark.Disabled('reference') # http://crbug.com/628631
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8MobileClassicBrowsingBenchmark(_V8MobileBrowsingBenchmark):
PLATFORM = 'mobile'
- TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8MobileClassicBrowsingBenchmark, self).SetExtraBrowserOptions(
options)
v8_helper.EnableClassic(options)
+ @classmethod
+ def Name(cls):
+ return 'v8.browsing_mobile_classic'
+
@benchmark.Owner(emails=['mythria@chromium.org'])
class V8RuntimeStatsDesktopBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'desktop'
- TEST_SUFFIX = ''
@classmethod
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
+ @classmethod
+ def Name(cls):
+ return 'v8.runtimestats.browsing_desktop'
+
@benchmark.Disabled('reference') # http://crbug.com/700390
@benchmark.Disabled('all')
@@ -236,7 +250,6 @@ class V8RuntimeStatsDesktopBrowsingBenchmark(
class V8RuntimeStatsDesktopTurboBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'desktop'
- TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsDesktopTurboBrowsingBenchmark,
@@ -247,13 +260,16 @@ class V8RuntimeStatsDesktopTurboBrowsingBenchmark(
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
+ @classmethod
+ def Name(cls):
+ return 'v8.runtimestats.browsing_desktop_turbo'
+
@benchmark.Disabled('reference') # http://crbug.com/700390
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8RuntimeStatsDesktopClassicBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'desktop'
- TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsDesktopClassicBrowsingBenchmark,
@@ -264,18 +280,26 @@ class V8RuntimeStatsDesktopClassicBrowsingBenchmark(
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
+ @classmethod
+ def Name(cls):
+ return 'v8.runtimestats.browsing_desktop_classic'
+
+
@benchmark.Disabled('reference') # http://crbug.com/694658
@benchmark.Owner(emails=['mythria@chromium.org'])
class V8RuntimeStatsMobileBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'mobile'
- TEST_SUFFIX = ''
@classmethod
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
+ @classmethod
+ def Name(cls):
+ return 'v8.runtimestats.browsing_mobile'
+
@benchmark.Disabled('reference') # http://crbug.com/694658
@benchmark.Disabled('all')
@@ -283,7 +307,6 @@ class V8RuntimeStatsMobileBrowsingBenchmark(
class V8RuntimeStatsMobileTurboBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'mobile'
- TEST_SUFFIX = '_turbo'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsMobileTurboBrowsingBenchmark,
@@ -294,13 +317,16 @@ class V8RuntimeStatsMobileTurboBrowsingBenchmark(
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
+ @classmethod
+ def Name(cls):
+ return 'v8.runtimestats.browsing_mobile_turbo'
+
@benchmark.Disabled('reference') # http://crbug.com/694658
@benchmark.Owner(emails=['hablich@chromium.org'])
class V8RuntimeStatsMobileClassicBrowsingBenchmark(
_V8RuntimeStatsBrowsingBenchmark):
PLATFORM = 'mobile'
- TEST_SUFFIX = '_classic'
def SetExtraBrowserOptions(self, options):
super(V8RuntimeStatsMobileClassicBrowsingBenchmark,
@@ -310,3 +336,7 @@ class V8RuntimeStatsMobileClassicBrowsingBenchmark(
@classmethod
def ShouldDisable(cls, possible_browser):
return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
+
+ @classmethod
+ def Name(cls):
+ return 'v8.runtimestats.browsing_mobile_classic'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698