Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2752273002:
Replace v8 benchmark names with rawstring (Closed)
DescriptionReplace v8 benchmark names with rawstring
Generating benchmark name with code makes it hard to code search for a benchmark.
Review-Url: https://codereview.chromium.org/2752273002
Cr-Commit-Position: refs/heads/master@{#457775}
Committed: https://chromium.googlesource.com/chromium/src/+/25c93363a3652e776c97ef9ea91ab11a6cd9fd28
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove left over TEST_SUFFIX #Messages
Total messages: 17 (9 generated)
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
nednguyen@google.com changed reviewers: + hablich@chromium.org, mythria@chromium.org, ulan@chromium.org
Extra eyes of reviewing will be much appreciated :P
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... tools/perf/benchmarks/v8_browsing.py:309: PLATFORM = 'mobile' I suppose all PLATFORM and TEST_SUFFIX need to be removed?
On 2017/03/17 10:48:13, Michael Hablich wrote: > https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... > tools/perf/benchmarks/v8_browsing.py:309: PLATFORM = 'mobile' > I suppose all PLATFORM and TEST_SUFFIX need to be removed? The PLATFORM is used to pick the right system health stories set (desktop vs mobile)
lgtm. https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... tools/perf/benchmarks/v8_browsing.py:310: TEST_SUFFIX = '_turbo' I think this TEST_SUFFIX can be removed. In all other places it is removed.
On 2017/03/17 11:13:29, mythria wrote: > lgtm. > > https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2752273002/diff/1/tools/perf/benchmarks/v8_br... > tools/perf/benchmarks/v8_browsing.py:310: TEST_SUFFIX = '_turbo' > I think this TEST_SUFFIX can be removed. In all other places it is removed. lgtm
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org, mythria@chromium.org, hablich@chromium.org Link to the patchset: https://codereview.chromium.org/2752273002/#ps20001 (title: "Remove left over TEST_SUFFIX")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489756079597400,
"parent_rev": "27885745a25ab23665dd420b6b9443e9b2171284", "commit_rev":
"25c93363a3652e776c97ef9ea91ab11a6cd9fd28"}
Message was sent while issue was closed.
Description was changed from ========== Replace v8 benchmark names with rawstring Generating benchmark name with code makes it hard to code search for a benchmark. ========== to ========== Replace v8 benchmark names with rawstring Generating benchmark name with code makes it hard to code search for a benchmark. Review-Url: https://codereview.chromium.org/2752273002 Cr-Commit-Position: refs/heads/master@{#457775} Committed: https://chromium.googlesource.com/chromium/src/+/25c93363a3652e776c97ef9ea91a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/25c93363a3652e776c97ef9ea91a... |
