Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2752253003: DevTools: Refactor Timeline.TimelineUIUtils.buildPicturePreviewContent to be async (Closed)

Created:
3 years, 9 months ago by alph
Modified:
3 years, 8 months ago
Reviewers:
caseq, dgozman, lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Refactor Timeline.TimelineUIUtils.buildPicturePreviewContent to be async Review-Url: https://codereview.chromium.org/2752253003 Cr-Commit-Position: refs/heads/master@{#460473} Committed: https://chromium.googlesource.com/chromium/src/+/b0017dec5002e248c2ed120a719d7642158e69f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -42 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 2 chunks +26 lines, -42 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
3 years, 9 months ago (2017-03-16 17:56:31 UTC) #2
dgozman
lgtm
3 years, 9 months ago (2017-03-16 18:11:56 UTC) #3
caseq
lgtm
3 years, 9 months ago (2017-03-16 18:13:20 UTC) #4
lushnikov
beautiful! lgtm, let's land this!
3 years, 9 months ago (2017-03-17 18:28:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752253003/1
3 years, 8 months ago (2017-03-29 17:26:58 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-03-29 18:57:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b0017dec5002e248c2ed120a719d...

Powered by Google App Engine
This is Rietveld 408576698