Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2752243002: Small cleanup in content MessagePort watcher usage (Closed)

Created:
3 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small cleanup in content MessagePort watcher usage Makes the lifetime management of the State object a little clearer. This change was supposed to make it into the CL which introduced the new watcher API, but it got dropped somehow. BUG=700171 R=jam@chromium.org Review-Url: https://codereview.chromium.org/2752243002 Cr-Commit-Position: refs/heads/master@{#457448} Committed: https://chromium.googlesource.com/chromium/src/+/1ab02803664abf6094e39d124ab83bfe7c418587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M content/common/message_port.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/message_port.cc View 4 chunks +11 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Ken Rockot(use gerrit already)
3 years, 9 months ago (2017-03-16 14:43:57 UTC) #4
jam
lgtm
3 years, 9 months ago (2017-03-16 15:43:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752243002/1
3 years, 9 months ago (2017-03-16 15:45:42 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 15:57:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ab02803664abf6094e39d124ab8...

Powered by Google App Engine
This is Rietveld 408576698