bindings: Add the proper includes for unions inside records

bindings: Add the proper includes for unions inside records

While https://codereview.chromium.org/2749253002 took care of adding all
required includes and forward-declarations for unions inside records inside
other unions, it did not solve it for unions inside records which were _not_
inside other unions: in this case, v8_union is not used at all, so we need
to patch code_generator_v8.depending_union_type() instead.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2752223002
Cr-Commit-Position: refs/heads/master@{#457404}
Committed: https://chromium.googlesource.com/chromium/src/+/73201f61646ab7e1c2aca0a5bd5994aa82958e42

[Raphael Kubo da Costa (rakuco), 2017-03-16 10:50:35]

PTAL; small follow-up to the record<K,V> work that I noticed while working on
the nested union patches.

[Raphael Kubo da Costa (rakuco), 2017-03-16 10:50:40]

The CQ bit was checked by raphael.kubo.da.costa@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 10:50:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-03-16 10:52:26]

LGTM

[commit-bot: I haz the power, 2017-03-16 12:10:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 12:10:38]

Dry run: This issue passed the CQ dry run.

[Raphael Kubo da Costa (rakuco), 2017-03-16 12:10:44]

The CQ bit was checked by raphael.kubo.da.costa@intel.com

[commit-bot: I haz the power, 2017-03-16 12:10:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 12:15:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489666244947190, "parent_rev":
"f84f9f576720345c30d23204e6329ed2204d1903", "commit_rev":
"73201f61646ab7e1c2aca0a5bd5994aa82958e42"}

[commit-bot: I haz the power, 2017-03-16 12:16:15]

Description was changed from

==========
bindings: Add the proper includes for unions inside records

While https://codereview.chromium.org/2749253002 took care of adding all
required includes and forward-declarations for unions inside records inside
other unions, it did not solve it for unions inside records which were _not_
inside other unions: in this case, v8_union is not used at all, so we need
to patch code_generator_v8.depending_union_type() instead.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org
==========

to

==========
bindings: Add the proper includes for unions inside records

While https://codereview.chromium.org/2749253002 took care of adding all
required includes and forward-declarations for unions inside records inside
other unions, it did not solve it for unions inside records which were _not_
inside other unions: in this case, v8_union is not used at all, so we need
to patch code_generator_v8.depending_union_type() instead.

BUG=685754
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2752223002
Cr-Commit-Position: refs/heads/master@{#457404}
Committed:
https://chromium.googlesource.com/chromium/src/+/73201f61646ab7e1c2aca0a5bd59...
==========

[commit-bot: I haz the power, 2017-03-16 12:16:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73201f61646ab7e1c2aca0a5bd59...

[bashi, 2017-03-16 12:20:48]

lgtm

[Yuki, 2017-03-16 13:31:03]

LGTM.