Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2752203003: Expand ignore whitelist to include FutureOr (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org, srawlins, keertip
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand ignore whitelist to include FutureOr See internal bug 36371258. We're hitting type errors of the form: CastError: Casting value of type '_Future' to incompatible type 'FutureOr<int>' I suspect these type errors were there but just ignored before - does this seem a reasonable extension to the whitelist? R=jmesserly@google.com Committed: https://github.com/dart-lang/sdk/commit/24fd5ced4f27d8135f5d85842e6f1d8b40c4547b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 9 months ago (2017-03-17 01:03:54 UTC) #3
Jennifer Messerly
lgtm ... but like, we're fast running out of time to remove this entire whitelist ...
3 years, 9 months ago (2017-03-17 01:17:08 UTC) #4
vsm
3 years, 9 months ago (2017-03-17 03:05:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24fd5ced4f27d8135f5d85842e6f1d8b40c4547b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698