pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart - Issue 2752203003: Expand ignore whitelist to include FutureOr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

Issue 2752203003: Expand ignore whitelist to include FutureOr (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

diff --git a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

index aeae578522840f35ce0c2e26a118495ab2ac76dd..20001cef3e56793e142b78209742336743dc07ec 100644

--- a/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

+++ b/pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

@@ -471,7 +471,7 @@ final _ignoreTypeFailure = JS(

// This is primarily due to the lack of generic methods,

// but we need to triage all the types.

if (!!$isSubtype(type, $Iterable) && !!$isSubtype(actual, $Iterable) ||

- !!$isSubtype(type, $Future) && !!$isSubtype(actual, $Future) ||

+ !!$isSubtype(type, $FutureOr) && !!$isSubtype(actual, $Future) ||

!!$isSubtype(type, $Map) && !!$isSubtype(actual, $Map) ||

$isFunctionType(type) && $isFunctionType(actual) ||

!!$isSubtype(type, $Stream) && !!$isSubtype(actual, $Stream) ||

« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/types.dart » ('j') | no next file with comments »