Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2752193002: Merge 3029: Remove floating objects from descendants of subtree roots (Closed)

Created:
3 years, 9 months ago by kojii
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Merge 3029: Remove floating objects from descendants of subtree roots The pre-layout for orthogonal flow clears floats from its containing block in [1]. However, this can cause trouble for markAllDescendantsWithFloatsForLayout() to mark descendants for layout. When preceding floats overhanging to following blocks are gone, such floats are referred from multiple following blocks including descendants. Failure to mark descendants for layout may leave preceding floats. This patch ensures such floats are removed. [1] https://codereview.chromium.org/2025543002 BUG=698455 Review-Url: https://codereview.chromium.org/2737253003 Cr-Commit-Position: refs/heads/master@{#456300} (cherry picked from commit c020f6a22577978ce1fe89fc1a397f2a651c48a8) Review-Url: https://codereview.chromium.org/2752193002 . Cr-Commit-Position: refs/branch-heads/3029@{#230} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/285585b19c24f98a5b25d8536e5950c18db3a847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/fast/writing-mode/orthogonal-writing-modes-floats-crash-3.html View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
kojii
3 years, 9 months ago (2017-03-16 07:00:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
285585b19c24f98a5b25d8536e5950c18db3a847.

Powered by Google App Engine
This is Rietveld 408576698