Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2752173002: MD Bookmarks: Remove old bookmark data store (Closed)

Created:
3 years, 9 months ago by tsergeant
Modified:
3 years, 9 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, arv+watch_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Bookmarks: Remove old bookmark data store MD Bookmarks has transitioned to a new data store and data flow method (see bug for context). This removes the old store (store.js), and moves the new store to take its place (from bookmarks_store.js to store.js). BUG=697706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2752173002 Cr-Commit-Position: refs/heads/master@{#458713} Committed: https://chromium.googlesource.com/chromium/src/+/75cea57aed3c1d1fa6c43d60f33a48501f62df4f

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -1043 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/resources/md_bookmarks/bookmarks_store.js View 1 chunk +0 lines, -100 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/compiled_resources2.gyp View 1 2 5 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/store.html View 1 chunk +1 line, -14 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/store.js View 1 chunk +77 lines, -442 lines 0 comments Download
M chrome/browser/ui/webui/md_bookmarks/md_bookmarks_ui.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/md_bookmarks_browsertest.js View 1 2 2 chunks +14 lines, -28 lines 0 comments Download
D chrome/test/data/webui/md_bookmarks/store_test.js View 1 chunk +0 lines, -442 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
tsergeant
Here's the deletion we've all been waiting for
3 years, 9 months ago (2017-03-21 02:03:32 UTC) #3
calamity
lgtm!
3 years, 9 months ago (2017-03-22 00:41:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752173002/20001
3 years, 9 months ago (2017-03-22 05:48:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/63836)
3 years, 9 months ago (2017-03-22 07:08:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752173002/20001
3 years, 9 months ago (2017-03-22 07:17:07 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/391308)
3 years, 9 months ago (2017-03-22 07:22:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752173002/40001
3 years, 9 months ago (2017-03-22 09:15:59 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/345259)
3 years, 9 months ago (2017-03-22 10:13:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752173002/40001
3 years, 9 months ago (2017-03-22 10:42:13 UTC) #19
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 11:12:22 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75cea57aed3c1d1fa6c43d60f33a...

Powered by Google App Engine
This is Rietveld 408576698