Fix testContextMenuOpenInNewTabFromTallPage.

Fix testContextMenuOpenInNewTabFromTallPage.

This test was flaky because it wasn't always reaching the bottom of the
page when swiping up. Add a call to grey_scrollToContentEdge to
guarantee the bottom edge is reached, making the link tappable.

BUG=701104
Review-Url: https://codereview.chromium.org/2752153004
Cr-Commit-Position: refs/heads/master@{#457465}
Committed: https://chromium.googlesource.com/chromium/src/+/aec6318cfecad2ee81a43bb084c8720826d76947

[baxley, 2017-03-16 14:41:33]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2017-03-16 14:41:33]

Sorry for the mess of CLs. I created a new one to fix this, which will make the
previous one obsolete:
https://codereview.chromium.org/2748873002/

I could have only called grey_scrollToContentEdge, but that took ~10 seconds to
reach the bottom, so kept the call to the one that swipes quickly.

I think I'll do a follow up CL to create a helper (or use one if it exists) that
doesn't require passing in WebState to WebViewScrollView, I think there's one
for the web shell.

[Eugene But (OOO till 7-30), 2017-03-16 16:54:52]

lgtm

https://codereview.chromium.org/2752153004/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2752153004/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/context_menu/context_menu_egtest.mm:223:
performAction:grey_scrollToContentEdge(kGREYContentEdgeBottom)];
It's pretty bad that |grey_scrollToContentEdge| is so slow that callers have to
use |grey_swipeFastInDirection| first. Do you want to file a bug against EG and
add a TODO to clean this up?

[baxley, 2017-03-16 17:05:14]

https://codereview.chromium.org/2752153004/diff/20001/ios/chrome/browser/cont...
File ios/chrome/browser/context_menu/context_menu_egtest.mm (right):

https://codereview.chromium.org/2752153004/diff/20001/ios/chrome/browser/cont...
ios/chrome/browser/context_menu/context_menu_egtest.mm:223:
performAction:grey_scrollToContentEdge(kGREYContentEdgeBottom)];
On 2017/03/16 16:54:52, Eugene But wrote:
> It's pretty bad that |grey_scrollToContentEdge| is so slow that callers have
to
> use |grey_swipeFastInDirection| first. Do you want to file a bug against EG
and
> add a TODO to clean this up?
Done.
Yeah, I agree that it's so slow. For a lot of tests it can be fine to just use
that, but this is a really long webpage. I filed a bug to track this, and I'll
reply to the existing EG issue about this to see if they want to do that. The
downside is it adds even more scroll/swipe APIs, but it doesn't hurt to address
it.

[baxley, 2017-03-16 17:05:23]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-03-16 17:05:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2752153004/#ps40001
(title: "add todo")

[commit-bot: I haz the power, 2017-03-16 17:06:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 17:14:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489683923403360,
"parent_rev": "6e62a5770c75bce60af3a8f91866e2ea7dcbf3bf", "commit_rev":
"aec6318cfecad2ee81a43bb084c8720826d76947"}

[commit-bot: I haz the power, 2017-03-16 17:15:18]

Description was changed from

==========
Fix testContextMenuOpenInNewTabFromTallPage.

This test was flaky because it wasn't always reaching the bottom of the
page when swiping up. Add a call to grey_scrollToContentEdge to
guarantee the bottom edge is reached, making the link tappable.

BUG=701104
==========

to

==========
Fix testContextMenuOpenInNewTabFromTallPage.

This test was flaky because it wasn't always reaching the bottom of the
page when swiping up. Add a call to grey_scrollToContentEdge to
guarantee the bottom edge is reached, making the link tappable.

BUG=701104

Review-Url: https://codereview.chromium.org/2752153004
Cr-Commit-Position: refs/heads/master@{#457465}
Committed:
https://chromium.googlesource.com/chromium/src/+/aec6318cfecad2ee81a43bb084c8...
==========

[commit-bot: I haz the power, 2017-03-16 17:15:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/aec6318cfecad2ee81a43bb084c8...