Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2752153002: memory coordinator: Change tracing event category (Closed)

Created:
3 years, 9 months ago by bashi
Modified:
3 years, 9 months ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

memory coordinator: Change tracing event category Before this CL we used "memory-infra" category for memory coordinator related events. Enabling "memory-infra" category triggers memory dump tasks but in some cases we just want to record memory coordinator related events without memory dumps to investigate performace impact of memory coordinator (e.g. how purging memory affects tab switching). This CL changes the category of memory coordinator related events to "memory_coordinator" so that we can recard traces without memory dumps. BUG=617492 Review-Url: https://codereview.chromium.org/2752153002 Cr-Commit-Position: refs/heads/master@{#457405} Committed: https://chromium.googlesource.com/chromium/src/+/58f641e2daf00d18ce899adc30fa92abaaa26e5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/browser/memory/memory_coordinator_impl.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/child/memory/child_memory_coordinator_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
bashi
PTAL
3 years, 9 months ago (2017-03-16 02:51:57 UTC) #4
tasak
lgtm
3 years, 9 months ago (2017-03-16 07:41:48 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-16 08:40:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752153002/1
3 years, 9 months ago (2017-03-16 12:11:28 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 12:17:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58f641e2daf00d18ce899adc30fa...

Powered by Google App Engine
This is Rietveld 408576698