 Chromium Code Reviews
 Chromium Code Reviews Issue 2752143003:
  [regexp] Remove remainder of native RegExpExecStub  (Closed)
    
  
    Issue 2752143003:
  [regexp] Remove remainder of native RegExpExecStub  (Closed) 
  | Index: src/regexp/mips64/regexp-macro-assembler-mips64.cc | 
| diff --git a/src/regexp/mips64/regexp-macro-assembler-mips64.cc b/src/regexp/mips64/regexp-macro-assembler-mips64.cc | 
| index e0317dec8a6d77b9e671a8a1b3918f4134e67442..8bfdd02e71284873c8106c2f1712ea0beab1c35f 100644 | 
| --- a/src/regexp/mips64/regexp-macro-assembler-mips64.cc | 
| +++ b/src/regexp/mips64/regexp-macro-assembler-mips64.cc | 
| @@ -17,7 +17,9 @@ namespace v8 { | 
| namespace internal { | 
| #ifndef V8_INTERPRETED_REGEXP | 
| -/* | 
| + | 
| +/* clang-format off | 
| + * | 
| * This assembler uses the following register assignment convention | 
| * - t3 : Temporarily stores the index of capture start after a matching pass | 
| * for a global regexp. | 
| @@ -74,9 +76,8 @@ namespace internal { | 
| * | 
| * The N64 stack will have the following structure: | 
| * | 
| - * - fp[88] Isolate* isolate (address of the current isolate) kIsolate | 
| - * - fp[80] secondary link/return address used by exit frame on native call. kSecondaryReturnAddress | 
| - kStackFrameHeader | 
| + * - fp[80] Isolate* isolate (address of the current isolate) kIsolate | 
| 
georgia.kouveli
2017/04/19 15:57:26
The corresponding comments for arm and arm64 are a
 
jgruber
2017/04/20 09:37:47
Thanks, good point. I made a pass through the comm
 | 
| + * kStackFrameHeader | 
| * --- sp when called --- | 
| * - fp[72] ra Return from RegExp code (ra). kReturnAddress | 
| * - fp[64] s9, old-fp Old fp, callee saved(s9). | 
| @@ -125,6 +126,8 @@ namespace internal { | 
| * area is overwritten with the ra register by the RegExp code. When doing a | 
| * direct call from generated code, the return address is placed there by | 
| 
georgia.kouveli
2017/04/19 15:57:26
Another mention of the return address and exit fra
 
jgruber
2017/04/20 09:37:47
Removed this entire paragraph.
 | 
| * the calling code, as in a normal exit frame. | 
| + * | 
| + * clang-format on | 
| */ | 
| #define __ ACCESS_MASM(masm_) |