Use SimpleQueue in WritableStream implementation

Use SimpleQueue in WritableStream implementation

Split out Queue into a separate file from ReadableStream and rename is
SimpleQueue to reduce the risk of name collisions on the binding object.

Add a peek() method as it is needed by WritableStream.

Modify WritableStream to use SimpleQueue.

BUG=681493
Review-Url: https://codereview.chromium.org/2752133003
Cr-Commit-Position: refs/heads/master@{#458324}
Committed: https://chromium.googlesource.com/chromium/src/+/e123782556b8f18f3a070722dd68ab617a930976

[Adam Rice, 2017-03-16 11:48:11]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 11:48:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-03-16 11:51:17]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 11:51:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Adam Rice, 2017-03-16 11:51:53]

ricea@chromium.org changed reviewers:
+ yhirano@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:18:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 15:18:02]

Dry run: This issue passed the CQ dry run.

[yhirano, 2017-03-17 13:56:46]

lgtm

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:994: // Modified from
taking the queue (as in the spec) to taking the stream, so we
Not related to this change but the comment is a bit stale, I believe.
DequeueValue originally took a stream but it now takes a controller.

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/SimpleQueue.js (right):

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/SimpleQueue.js:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
2017

[Adam Rice, 2017-03-17 14:02:10]

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/ReadableStream.js (right):

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/ReadableStream.js:994: // Modified from
taking the queue (as in the spec) to taking the stream, so we
On 2017/03/17 13:56:45, yhirano wrote:
> Not related to this change but the comment is a bit stale, I believe.
> DequeueValue originally took a stream but it now takes a controller.

Good point. I removed the stale comments here and in WritableStream. I still
have a TODO to combine them.

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/streams/SimpleQueue.js (right):

https://codereview.chromium.org/2752133003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/streams/SimpleQueue.js:1: // Copyright 2016 The
Chromium Authors. All rights reserved.
On 2017/03/17 13:56:45, yhirano wrote:
> 2017

Done.

[Adam Rice, 2017-03-17 14:03:46]

ricea@chromium.org changed reviewers:
+ brettw@chromium.org

[Adam Rice, 2017-03-17 14:03:46]

+brettw Let me know if you're bored of streams CLs and I'll pick on someone
else.

[Adam Rice, 2017-03-17 14:04:06]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 14:04:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:19:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[brettw, 2017-03-20 19:45:57]

If you're changing the V8 parameters that Chrome uses in //.gn, I'm fine with
you TBR-ing me in the future.

I didn't look at the .js files. LGTM for .gn

[Adam Rice, 2017-03-21 04:33:57]

The CQ bit was checked by ricea@chromium.org

[Adam Rice, 2017-03-21 04:33:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2752133003/#ps60001
(title: "Remove stale comments and correct copyright date")

[commit-bot: I haz the power, 2017-03-21 04:34:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 06:26:33]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490070837977250,
"parent_rev": "f2c7dc50ceb57308a7c293562e1780fd8013c8fd", "commit_rev":
"e123782556b8f18f3a070722dd68ab617a930976"}

[commit-bot: I haz the power, 2017-03-21 06:27:52]

Description was changed from

==========
Use SimpleQueue in WritableStream implementation

Split out Queue into a separate file from ReadableStream and rename is
SimpleQueue to reduce the risk of name collisions on the binding object.

Add a peek() method as it is needed by WritableStream.

Modify WritableStream to use SimpleQueue.

BUG=681493
==========

to

==========
Use SimpleQueue in WritableStream implementation

Split out Queue into a separate file from ReadableStream and rename is
SimpleQueue to reduce the risk of name collisions on the binding object.

Add a peek() method as it is needed by WritableStream.

Modify WritableStream to use SimpleQueue.

BUG=681493

Review-Url: https://codereview.chromium.org/2752133003
Cr-Commit-Position: refs/heads/master@{#458324}
Committed:
https://chromium.googlesource.com/chromium/src/+/e123782556b8f18f3a070722dd68...
==========

[commit-bot: I haz the power, 2017-03-21 06:27:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e123782556b8f18f3a070722dd68...