Fix CHECK that's being fired inside NavigationControllerImpl::RendererDidNavigateToExistingPage.

Fix CHECK that's being fired inside NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and apparently it is. Add logic to not copy the cert for in-page navigations. I didn't add logic to handle the restore case since intended_as_new_entry shouldn't be set in that scenario.

BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2752113007
Cr-Commit-Position: refs/heads/master@{#457818}
Committed: https://chromium.googlesource.com/chromium/src/+/1325c82018ee533b2d88ac923bfb516b4f552555

[jam, 2017-03-17 17:10:07]

Description was changed from

==========
Fix CHECK that's being fired inside
NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and
apparently it is. Add logic to not copy the cert for in-page navigations. I
didn't add logic to handle the restore case since intended_as_new_entry
shouldn't be set in that scenario.

BUG=697827
==========

to

==========
Fix CHECK that's being fired inside
NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and
apparently it is. Add logic to not copy the cert for in-page navigations. I
didn't add logic to handle the restore case since intended_as_new_entry
shouldn't be set in that scenario.

BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-17 17:10:15]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 17:10:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2017-03-17 17:39:03]

Description was changed from

==========
Fix CHECK that's being fired inside
NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and
apparently it is. Add logic to not copy the cert for in-page navigations. I
didn't add logic to handle the restore case since intended_as_new_entry
shouldn't be set in that scenario.

BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix CHECK that's being fired inside
NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and
apparently it is. Add logic to not copy the cert for in-page navigations. I
didn't add logic to handle the restore case since intended_as_new_entry
shouldn't be set in that scenario.

BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jam, 2017-03-17 17:39:03]

jam@chromium.org changed reviewers:
+ estark@chromium.org

[jam, 2017-03-17 17:50:13]

I don't have a repro unfortunately, because it's just a CHECK that's firing.

[estark, 2017-03-17 18:09:18]

lgtm

We could use DumpWithoutCrashing again to find out more about how this is
happening... but probably not worth it since it seems likely that this will get
illuminated as part of https://crbug.com/596707 (classifying location.replace
correctly).

[jam, 2017-03-17 18:10:37]

The CQ bit was unchecked by jam@chromium.org

[jam, 2017-03-17 18:10:40]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:20:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489774240732470, "parent_rev":
"364a557a2bdad974a06b6a74ce46520b26ebba3c", "commit_rev":
"1325c82018ee533b2d88ac923bfb516b4f552555"}

[commit-bot: I haz the power, 2017-03-17 18:22:02]

Description was changed from

==========
Fix CHECK that's being fired inside
NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and
apparently it is. Add logic to not copy the cert for in-page navigations. I
didn't add logic to handle the restore case since intended_as_new_entry
shouldn't be set in that scenario.

BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Fix CHECK that's being fired inside
NavigationControllerImpl::RendererDidNavigateToExistingPage.

The check was supposed to alert us if this condition is being hit, and
apparently it is. Add logic to not copy the cert for in-page navigations. I
didn't add logic to handle the restore case since intended_as_new_entry
shouldn't be set in that scenario.

BUG=697827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2752113007
Cr-Commit-Position: refs/heads/master@{#457818}
Committed:
https://chromium.googlesource.com/chromium/src/+/1325c82018ee533b2d88ac923bfb...
==========

[commit-bot: I haz the power, 2017-03-17 18:22:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1325c82018ee533b2d88ac923bfb...