Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2752113002: Moved WebView(ScrollView)Proxy files to ui subdirectory. (Closed)

Created:
3 years, 9 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 9 months ago
Reviewers:
michaeldo
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, ios-reviews+web_chromium.org, mahmadi+paymentsioswatch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved WebView(ScrollView)Proxy files to ui subdirectory. BUG=389405 Review-Url: https://codereview.chromium.org/2752113002 Cr-Commit-Position: refs/heads/master@{#457470} Committed: https://chromium.googlesource.com/chromium/src/+/4648799d30f26870f9e56e0602fe115b57975fd8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -875 lines) Patch
M ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_suggestion_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_suggestion_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/find_in_page/find_in_page_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/find_in_page/find_in_page_js_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_request_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/DEPS View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/fullscreen_controller_unittest.mm View 1 chunk +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/BUILD.gn View 6 chunks +6 lines, -6 lines 0 comments Download
M ios/web/public/test/web_view_interaction_test_util.mm View 1 chunk +2 lines, -2 lines 0 comments Download
D ios/web/public/web_state/crw_web_view_proxy.h View 1 chunk +0 lines, -77 lines 0 comments Download
D ios/web/public/web_state/crw_web_view_scroll_view_proxy.h View 1 chunk +0 lines, -94 lines 0 comments Download
A + ios/web/public/web_state/ui/crw_web_view_proxy.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + ios/web/public/web_state/ui/crw_web_view_scroll_view_proxy.h View 4 chunks +10 lines, -10 lines 0 comments Download
D ios/web/web_state/crw_web_view_proxy_impl.h View 1 chunk +0 lines, -28 lines 0 comments Download
D ios/web/web_state/crw_web_view_proxy_impl.mm View 1 chunk +0 lines, -182 lines 0 comments Download
D ios/web/web_state/crw_web_view_scroll_view_proxy.mm View 1 chunk +0 lines, -233 lines 0 comments Download
D ios/web/web_state/crw_web_view_scroll_view_proxy_unittest.mm View 1 chunk +0 lines, -166 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 3 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view_unittest.mm View 1 chunk +4 lines, -3 lines 0 comments Download
A + ios/web/web_state/ui/crw_web_view_proxy_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ios/web/web_state/ui/crw_web_view_proxy_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + ios/web/web_state/ui/crw_web_view_scroll_view_proxy.mm View 2 chunks +6 lines, -6 lines 0 comments Download
A + ios/web/web_state/ui/crw_web_view_scroll_view_proxy_unittest.mm View 4 chunks +33 lines, -34 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 9 months ago (2017-03-15 20:55:54 UTC) #2
michaeldo
lgtm!
3 years, 9 months ago (2017-03-16 15:14:46 UTC) #7
Eugene But (OOO till 7-30)
Thanks!
3 years, 9 months ago (2017-03-16 17:09:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752113002/1
3 years, 9 months ago (2017-03-16 17:10:18 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 17:22:19 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4648799d30f26870f9e56e0602fe...

Powered by Google App Engine
This is Rietveld 408576698