Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 2752093004: Makes KeyEvent struct traits restore Event::time_stamp() field (Closed)

Created:
3 years, 9 months ago by sky
Modified:
3 years, 9 months ago
Reviewers:
Tom Sepez, sadrul
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes KeyEvent struct traits restore Event::time_stamp() field Prior to this the time_stamp() of KeyEvents was not deserialized correctly. BUG=701815 TEST=covered by tests R=sadrul@chromium.org, tsepez@chromium.org Review-Url: https://codereview.chromium.org/2752093004 Cr-Commit-Position: refs/heads/master@{#457605} Committed: https://chromium.googlesource.com/chromium/src/+/3ecf94ff51f5ae1721c8743d53ca5c92743b8699

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
M ui/events/event.h View 2 chunks +8 lines, -2 lines 0 comments Download
M ui/events/event.cc View 2 chunks +14 lines, -8 lines 0 comments Download
M ui/events/mojo/event_struct_traits.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/events/mojo/struct_traits_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
3 years, 9 months ago (2017-03-16 21:18:23 UTC) #1
Tom Sepez
lgtm
3 years, 9 months ago (2017-03-16 21:50:17 UTC) #4
sadrul
lgtm
3 years, 9 months ago (2017-03-16 22:47:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752093004/1
3 years, 9 months ago (2017-03-16 23:16:38 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 23:38:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3ecf94ff51f5ae1721c8743d53ca...

Powered by Google App Engine
This is Rietveld 408576698