Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issue 2752093003: Remove hard-coded sdk build tools path from test_runner_py target. (Closed)

Created:
3 years, 9 months ago by mikecase (-- gone --)
Modified:
3 years, 9 months ago
Reviewers:
jbudorick, agrieve
CC:
agrieve+watch_chromium.org, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove hard-coded sdk build tools path from test_runner_py target. BUG=688263 Review-Url: https://codereview.chromium.org/2752093003 Cr-Commit-Position: refs/heads/master@{#457534} Committed: https://chromium.googlesource.com/chromium/src/+/9add10b813d77f81636bb8ddcd49c64ac3757e5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M build/android/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mikecase (-- gone --)
Any reason this was a hard-coded path?
3 years, 9 months ago (2017-03-16 18:36:55 UTC) #2
jbudorick
lgtm but link the N MR1 SDK bug On 2017/03/16 18:36:55, mikecase wrote: > Any ...
3 years, 9 months ago (2017-03-16 18:40:33 UTC) #3
agrieve
On 2017/03/16 18:40:33, jbudorick wrote: > lgtm but link the N MR1 SDK bug > ...
3 years, 9 months ago (2017-03-16 18:53:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752093003/1
3 years, 9 months ago (2017-03-16 18:55:11 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 20:24:20 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9add10b813d77f81636bb8ddcd49...

Powered by Google App Engine
This is Rietveld 408576698