Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2752073005: Disable ReloadCacheControlBrowserTest if PlzNavigate is enabled (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
kinuko, tzik
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ReloadCacheControlBrowserTest if PlzNavigate is enabled CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation TBR=kinuko@chromium.org BUG=671545, 670237 Review-Url: https://codereview.chromium.org/2752073005 Cr-Commit-Position: refs/heads/master@{#457384} Committed: https://chromium.googlesource.com/chromium/src/+/ea77fe5f9663714b8458b23dd996279baade45d6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/browser/loader/reload_cache_control_browsertest.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Takashi Toyoshima
manually add CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation line
3 years, 9 months ago (2017-03-16 08:42:00 UTC) #4
Takashi Toyoshima
Test failure in the waterfall looks happening on PlzNavigate enabled tests.
3 years, 9 months ago (2017-03-16 08:43:50 UTC) #7
Takashi Toyoshima
tzik, could you review this disabling test change as a tree sheriff?
3 years, 9 months ago (2017-03-16 08:44:27 UTC) #8
tzik
lgtm
3 years, 9 months ago (2017-03-16 08:46:20 UTC) #9
kinuko
lgtm
3 years, 9 months ago (2017-03-16 09:25:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752073005/1
3 years, 9 months ago (2017-03-16 09:30:14 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 09:36:04 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ea77fe5f9663714b8458b23dd996...

Powered by Google App Engine
This is Rietveld 408576698