Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2752073002: Avoid double initializing reporting_service_ (Closed)

Created:
3 years, 9 months ago by Steven Holte
Modified:
3 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid double initializing reporting_service_ Issue introduced in https://codereview.chromium.org/2608833002 ReportingService is already initialized by InitializeMetricsRecordingState, don't call Initialize again in InitializeMetricsState. Adds a DCHECK to Initialize to make sure it isn't called twice. BUG=693676 Review-Url: https://codereview.chromium.org/2752073002 Cr-Commit-Position: refs/heads/master@{#457214} Committed: https://chromium.googlesource.com/chromium/src/+/5576ba8067a8c06eec493384d17acec923b0d2b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M components/metrics/metrics_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/metrics/reporting_service.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Steven Holte
3 years, 9 months ago (2017-03-15 19:39:16 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-03-15 20:00:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752073002/1
3 years, 9 months ago (2017-03-15 20:23:06 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 21:28:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5576ba8067a8c06eec493384d17a...

Powered by Google App Engine
This is Rietveld 408576698